Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added numberOfAttempts to promptOptions #870

Merged
merged 3 commits into from
Apr 12, 2019
Merged

added numberOfAttempts to promptOptions #870

merged 3 commits into from
Apr 12, 2019

Conversation

johnataylor
Copy link
Member

Fixes microsoft/BotBuilder-Samples#1257

Description

Adds a numberOfAttempts property to the promptOptions

@coveralls
Copy link

Pull Request Test Coverage Report for Build #2178

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.666%
Totals Coverage Status
Change from base Build #2177: 0.06%
Covered Lines: 3202
Relevant Lines: 3509
💛 - Coveralls

@cleemullins cleemullins merged commit 96d3940 into master Apr 12, 2019
@cleemullins cleemullins deleted the johtaylo/issue1257js branch April 12, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@stevengum stevengum Awaiting requested review from stevengum

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Know the number of attempts inside a validation
3 participants
@johnataylor @coveralls @cleemullins