Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision is lost when switching conversions #177

Closed
jsoref opened this issue Mar 7, 2019 · 4 comments
Closed

Precision is lost when switching conversions #177

jsoref opened this issue Mar 7, 2019 · 4 comments
Labels
Area: User Experience Issue primarily affects end user experience and are not covered by other areas help wanted Issues identified as good community contribution opportunities not repro Pri: 2

Comments

@jsoref
Copy link
Contributor

jsoref commented Mar 7, 2019

Describe the bug

While general math does not lose precision (see #119), unit conversions do.

From my perspective, this is a bug, but I suspect fixing this would make it a feature request. I'm filing it as a bug because the information required here and the information I have available more closely fit the bug filing form.

Steps To Reproduce

  1. Open Calculator
  2. Tap ≡
  3. Tap Power
  4. Tap Kilowatts (top unit -- this computer is en-US not en-GB where the default is Watts)
  5. Step 1: (‎3/‎7/‎2019 11:10:37 AM) User left click on "Six (button)" in "Cal"
  6. Step 2: (‎3/‎7/‎2019 11:10:38 AM) User left click on "Zero (button)" in "Cal"
  7. Step 3: (‎3/‎7/‎2019 11:10:41 AM) User left click on "Converts into ‪3.412141‬ BTUs/minute (text)" in "Cal"
  8. Step 4: (‎3/‎7/‎2019 11:10:42 AM) User left click on "Input unit (combo box)" in "Cal"
  9. Step 5: (‎3/‎7/‎2019 11:10:43 AM) User left click on "Foot-pounds/minute (text)" in "Cal"
  10. Step 6: (‎3/‎7/‎2019 11:10:46 AM) User left click on "Input unit (combo box)" in "Cal"
  11. Step 7: (‎3/‎7/‎2019 11:10:47 AM) User left click on "BTUs/minute (text)" in "Cal"
  12. Step 8: (‎3/‎7/‎2019 11:10:49 AM) User left click on "Converts into ‪59.9999972482667‬ Watts (text)" in "Cal"
  13. Step 9: (‎3/‎7/‎2019 11:10:50 AM) User left click on "Steps Recorder - 1 running window (button)"

Expected behavior

Ideally it would still show 60 Watts in the top field.
This would require unit conversions to cooperate with the ratpack

Screenshots
image
image

Note: this was recorded w/ psr.exe, so I have screen shots for all of the recorded steps (and I could trivially re-record w/ the missing initial setup steps.

Device and Application Information (please complete the following information):

  • OS Build: 10.0.17134.0
  • Architecture: X64
  • Application Version: 10.1811.3241.0

Additional context

@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@grochocki
Copy link
Contributor

Thanks for the report! I really appreciate your thoroughness when filing this bug. I was able to verify this across other converters as well, including Speed and Pressure.

@grochocki grochocki added Bug Issue is a bug Pri: 3 triage approved Issue has been approved by Calculator team member Area: User Experience Issue primarily affects end user experience and are not covered by other areas and removed triage needed labels Mar 8, 2019
@grochocki grochocki added the help wanted Issues identified as good community contribution opportunities label Apr 30, 2019
@jsoref
Copy link
Contributor Author

jsoref commented May 28, 2019

Fwiw, I've started stepping through how to do this here:
https://github.com/jsoref/Microsoft-calculator/commits/issue-177

If someone familiar w/ RAT/PRAT could give me some pointers, I think this might be somewhat close to something. (I haven't touched the tests, nor have I fed this code to a compiler.)

@HowardWolosky
Copy link
Member

If someone familiar w/ RAT/PRAT could give me some pointers, I think this might be somewhat close to something. (I haven't touched the tests, nor have I fed this code to a compiler.)

cc @joshkoon

@grochocki grochocki added the hacktoberfest Hacktoberfest is a month-long celebration of open source software. label Sep 28, 2019
@grochocki grochocki removed the hacktoberfest Hacktoberfest is a month-long celebration of open source software. label Nov 12, 2019
@MicrosoftIssueBot MicrosoftIssueBot added not repro and removed triage approved Issue has been approved by Calculator team member labels Feb 6, 2020
@ghost ghost removed the help wanted Issues identified as good community contribution opportunities label Feb 6, 2020
@MicrosoftIssueBot MicrosoftIssueBot added the help wanted Issues identified as good community contribution opportunities label Feb 6, 2020
@MicrosoftIssueBot MicrosoftIssueBot removed the Bug Issue is a bug label Mar 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: User Experience Issue primarily affects end user experience and are not covered by other areas help wanted Issues identified as good community contribution opportunities not repro Pri: 2
Projects
None yet
Development

No branches or pull requests

4 participants