Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention arbitrary precision library somewhere in readme #119

Closed
Daniel15 opened this issue Mar 6, 2019 · 3 comments · Fixed by #470
Closed

Mention arbitrary precision library somewhere in readme #119

Daniel15 opened this issue Mar 6, 2019 · 3 comments · Fixed by #470
Labels
documentation help wanted Issues identified as good community contribution opportunities

Comments

@Daniel15
Copy link

Daniel15 commented Mar 6, 2019

IMO, this is one of the most interesting parts of Windows Calculator: It contains an arbitrary-precision arithmetic library rather than using regular floating point numbers, with infinite precision for basic operations (addition, subtraction, multiplication, division), so that calculations never lose precision. https://blogs.msdn.microsoft.com/oldnewthing/20040525-00/?p=39193

This would be great to mention in the readme somewhere... I'm not sure where though.

Of course, there's other big integer libraries these days, but it's still very interesting historical code. Looks like it's this header: https://github.com/Microsoft/calculator/blob/master/src/CalcManager/Ratpack/ratpak.h plus the files in that directory.

@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@JustinKaffenberger
Copy link

It's mentioned at the very end of the docs here, but I agree that it deserves more attention.

@danbelcher-MSFT
Copy link

Happy to accept help from the community here!

@danbelcher-MSFT danbelcher-MSFT removed their assignment Mar 14, 2019
@danbelcher-MSFT danbelcher-MSFT added the help wanted Issues identified as good community contribution opportunities label Mar 14, 2019
@MicrosoftIssueBot MicrosoftIssueBot added help wanted Issues identified as good community contribution opportunities and removed help wanted Issues identified as good community contribution opportunities labels Mar 14, 2019
HowardWolosky pushed a commit that referenced this issue Apr 23, 2019
Fixes #119

Added infinite precision as a feature in README.md and in ApplicationArchitecture.md

How changes were validated:
Manual preview of README and ApplicationArchitecture.md
EriWong pushed a commit to EriWong/calculator that referenced this issue Jun 5, 2019
Fixes microsoft#119

Added infinite precision as a feature in README.md and in ApplicationArchitecture.md

How changes were validated:
Manual preview of README and ApplicationArchitecture.md
@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants