Skip to content

Commit

Permalink
Fix lit testing using VS 2017. (#13)
Browse files Browse the repository at this point in the history
When clang is run under the lit testing harness on a Windows machine with
only VS 2017 installed, clang can't find the VS install directory.  This
can cause tests that do linking to fail.   The lit scripts are filtering
out the ProgramData environment variable.   Clang is using a VS 2017 library
for finding the VS 2017 install location, and the library depends on the
ProgramData environment variable being set correctly.  The fix is to not
filter out the ProgramData variable.
  • Loading branch information
dtarditi committed Feb 28, 2018
1 parent df68d5c commit d8d78c7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions utils/lit/lit/TestingConfig.py
Expand Up @@ -37,6 +37,7 @@ def fromdefaults(litConfig):
environment.update({
'INCLUDE' : os.environ.get('INCLUDE',''),
'PATHEXT' : os.environ.get('PATHEXT',''),
'PROGRAMDATA' : os.environ.get('PROGRAMDATA',''),
'PYTHONUNBUFFERED' : '1',
'TEMP' : os.environ.get('TEMP',''),
'TMP' : os.environ.get('TMP',''),
Expand Down

0 comments on commit d8d78c7

Please sign in to comment.