Fix lit testing using VS 2017. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clang is run under the lit testing harness on a Windows machine with only VS 2017 installed, clang can't find the VS install directory. This can cause tests that do linking to fail. The lit scripts are filtering out the ProgramData environment variable. Clang is using a VS 2017 library for finding the VS 2017 install location, and the library depends on the ProgramData environment variable being set correctly. The fix is to not filter out the ProgramData variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clang is run under the lit testing harness on a Windows machine with
only Visual Studio 2017 installed, clang can't find the VS install directory. This
can cause tests that do linking to fail. The lit scripts are filtering
out the ProgramData environment variable. Clang is using a VS library
for finding the VS install location, and the library depends on the
ProgramData environment variable being set correctly. The fix is to not
filter out the ProgramData variable.