Remove depends #125
Merged
Remove depends #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/homebrew_depends
ehanlon
approved these changes
Aug 2, 2018
|
This makes it a Chef 14+ cookbook only. You might wanna hold off on this |
|
Good point @tas50. We should at least target this for v3 instead. |
|
Do we actually depend on the homebrew cookbook anymore? |
|
@jazaval No. We previously needed to depend on the homebrew cookbook was when we installed |
jazaval
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #123
Removing the dependency on homebrew from metadata removes the warnings during builds.