Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't smoke test UID when testing user resource #153

Merged
merged 2 commits into from Oct 19, 2018

Conversation

jazaval
Copy link
Contributor

@jazaval jazaval commented Oct 19, 2018

This PR stops checking for the specific sequential uid after creating test cookbook users. We're not actually specifying a desired uid in the resource call, so this test is creating some false failures.

@americanhanko
Copy link
Collaborator

americanhanko commented Oct 19, 2018

Build failure caused by system_preference[disable computer sleep] resource being updated during second chef-client run when enforce_idempotence is true

2018-10-19T02:01:46.1415890Z        Recipe: macos::keep_awake
2018-10-19T02:01:46.1861110Z          * system_preference[disable computer sleep] action set
2018-10-19T02:01:46.1863180Z            - set computersleep to Never
2018-10-19T02:01:46.1864090Z            - update disable computer sleep
2018-10-19T02:01:46.1866080Z            -   set setting to "Never" (was "10")
2018-10-19T02:01:46.2337060Z            * execute[/usr/sbin/systemsetup, -setcomputersleep, Never] action run
2018-10-19T02:01:46.2337870Z              - execute ["/usr/sbin/systemsetup", "-setcomputersleep", "Never"]
2018-10-19T02:01:47.2341440Z            * ruby_block[sleep one second] action run
2018-10-19T02:01:47.2342620Z              - execute the ruby block sleep one second
2018-10-19T02:01:47.2345040Z          
2018-10-19T02:01:47.2792670Z          * system_preference[disable display sleep] action set (up to date)
2018-10-19T02:01:47.3212100Z          * system_preference[disable hard disk sleep] action set (up to date)
2018-10-19T02:01:47.3639180Z          * system_preference[restart if the computer becomes unresponsive] action set (up to date)
2018-10-19T02:01:47.3644110Z          * system_preference[wake the computer when accessed using a network connection] action set (skipped due to not_if)
2018-10-19T02:01:47.3649900Z          * system_preference[restart after a power failure] action set (skipped due to not_if)
2018-10-19T02:01:47.3656240Z          * system_preference[pressing power button does not sleep computer] action set (skipped due to only_if)
2018-10-19T02:01:47.3925690Z          * system_preference[allow remote apple events] action set (up to date)
2018-10-19T02:01:47.4184990Z          * system_preference[set the network time server] action set (up to date)
2018-10-19T02:01:47.4469490Z          * system_preference[set the time zone] action set (up to date)
2018-10-19T02:01:47.4838250Z          * system_preference[enable remote login] action set (up to date)
2018-10-19T02:01:47.5355250Z          * defaults[com.apple.screensaver] action run (skipped due to not_if)
2018-10-19T02:01:47.6085240Z        
2018-10-19T02:01:47.6085690Z        Running handlers:
2018-10-19T02:01:47.6085920Z        First chef run should have reached a converged state.
2018-10-19T02:01:47.6087080Z        Resources updated in a second chef-client run:
2018-10-19T02:01:47.6088950Z        - system_preference[disable computer sleep]
2018-10-19T02:01:47.6158850Z        [2018-10-18T19:00:37-07:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process terminated by signal 9 (KILL)
2018-10-19T02:01:47.6160820Z        [2018-10-18T19:00:37-07:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process terminated by signal 9 (KILL)

@mjmerin
Copy link
Member

mjmerin commented Oct 19, 2018

Don't forget to update the changelog.

@jazaval jazaval merged commit 9524ce2 into release/2.7 Oct 19, 2018
@jazaval jazaval deleted the hotfix/users-testing branch October 19, 2018 17:54
jazaval added a commit that referenced this pull request Oct 27, 2018
* bump version

* Fix #63 (#152)

* refactor screensaver class disabled method

* fix indentation

* delete some unit tests

* don't smoke test UID when testing user resource (#153)

* remove uid testing

* remove multi-converge, added to idempotency branch

* Add multi-converge testing for all suites, idempotency for select suites (#155)

* remove uid testing

* add multi-converge for all test recipes

* remove sleep

* just see if multi-converges pass

* add idempotency testing for specific suites

* add guard in spotlight test recipe

* guard against last test disk

* add a case if the index is in an unknown state

* add a sleep to allow indexing server to chill out

* add a 3rd converge

* create volume object in guard

* 2 converges for now

* increase sleep to allow indexing state to settle down

* enforce idempotency for spotlight

* add guard to test recipe item

* fix bug

* remove idempotency testing for xcode

* set three times

* Enforce idempotency for default ARD resource actions (#157)

* remove uid testing

* add multi-converge for all test recipes

* remove sleep

* just see if multi-converges pass

* add idempotency testing for specific suites

* add guard in spotlight test recipe

* guard against last test disk

* add a case if the index is in an unknown state

* add a sleep to allow indexing server to chill out

* add a 3rd converge

* create volume object in guard

* 2 converges for now

* increase sleep to allow indexing state to settle down

* enforce idempotency for spotlight

* add guard to test recipe item

* fix bug

* remove idempotency testing for xcode

* set three times

* add guard for ARD activation

* implement very basic guards

* add some unit tests for the ARD module

* remove some whitespace

* fix stub

* demystify magic mask string

* Feature/fix doc links (#158)

* update ard resource documentation

* more updates to ard resource docuemntation

* update certificate resource doccumentation

* update keychain resource doc

* update plist doc

* update spotlight resource doc

* update xcode resource doc

* change link location and fix syntax mistake

* add 2.7 changes to changelog (#159)

* add 2.7 changes to changelog

* add link to broken links issue

* add more details to changelog

* update CL

* Update CHANGELOG.md

Co-Authored-By: jazaval <jazava@microsoft.com>

* Update CHANGELOG.md

Co-Authored-By: jazaval <jazava@microsoft.com>

* remove whitespace

* grammar fix

Co-Authored-By: jazaval <jazava@microsoft.com>

* grammar fix

Co-Authored-By: jazaval <jazava@microsoft.com>

* grammar fix

Co-Authored-By: jazaval <jazava@microsoft.com>

* grammar fix

Co-Authored-By: jazaval <jazava@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants