Enforce idempotency for default ARD resource actions #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-access-idempotence
chrismarlin
reviewed
Oct 25, 2018
There was a problem hiding this comment.
from libraries/ard.rb...
remote_management_plist.include?('1073742079')
Didn't you and @mjmerin do some work to unobfuscate these ARD settings for readability.
mjmerin
approved these changes
Oct 25, 2018
ehanlon
approved these changes
Oct 25, 2018
v-anshie
approved these changes
Oct 25, 2018
jazaval
added a commit
that referenced
this pull request
Oct 27, 2018
* bump version * Fix #63 (#152) * refactor screensaver class disabled method * fix indentation * delete some unit tests * don't smoke test UID when testing user resource (#153) * remove uid testing * remove multi-converge, added to idempotency branch * Add multi-converge testing for all suites, idempotency for select suites (#155) * remove uid testing * add multi-converge for all test recipes * remove sleep * just see if multi-converges pass * add idempotency testing for specific suites * add guard in spotlight test recipe * guard against last test disk * add a case if the index is in an unknown state * add a sleep to allow indexing server to chill out * add a 3rd converge * create volume object in guard * 2 converges for now * increase sleep to allow indexing state to settle down * enforce idempotency for spotlight * add guard to test recipe item * fix bug * remove idempotency testing for xcode * set three times * Enforce idempotency for default ARD resource actions (#157) * remove uid testing * add multi-converge for all test recipes * remove sleep * just see if multi-converges pass * add idempotency testing for specific suites * add guard in spotlight test recipe * guard against last test disk * add a case if the index is in an unknown state * add a sleep to allow indexing server to chill out * add a 3rd converge * create volume object in guard * 2 converges for now * increase sleep to allow indexing state to settle down * enforce idempotency for spotlight * add guard to test recipe item * fix bug * remove idempotency testing for xcode * set three times * add guard for ARD activation * implement very basic guards * add some unit tests for the ARD module * remove some whitespace * fix stub * demystify magic mask string * Feature/fix doc links (#158) * update ard resource documentation * more updates to ard resource docuemntation * update certificate resource doccumentation * update keychain resource doc * update plist doc * update spotlight resource doc * update xcode resource doc * change link location and fix syntax mistake * add 2.7 changes to changelog (#159) * add 2.7 changes to changelog * add link to broken links issue * add more details to changelog * update CL * Update CHANGELOG.md Co-Authored-By: jazaval <jazava@microsoft.com> * Update CHANGELOG.md Co-Authored-By: jazaval <jazava@microsoft.com> * remove whitespace * grammar fix Co-Authored-By: jazaval <jazava@microsoft.com> * grammar fix Co-Authored-By: jazaval <jazava@microsoft.com> * grammar fix Co-Authored-By: jazaval <jazava@microsoft.com> * grammar fix Co-Authored-By: jazaval <jazava@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic guards to the ARD resource actions
[:activate, :configure]in order to resolve occurrences of bug #70 when using the default actions.The upcoming refactor of ARD will guard against more than the default actions, but will likely be part of the next major release, since the resource may have different properties.