Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to open this pull request now to start soliciting feedback and see what changes the maintainer(s) may suggest before taking this feature in.
We are using this functionality in production to allow for very easy configuration and deployment in the cloud using Azure App Service (WebJob to run the task), Git deployment - just update configuration files quickly, etc. - and then Azure KeyVault to store the secrets for the personal access tokens and/or passwords for both VSTS and Office 365 / EWS.
I found the relative consistency of the project all over the place, so there are some formatting changes in this diff that were introduced by a NuGet package update.
High-level changes:
Microsoft.Azure.KeyVault
NuGet package (this introduces some messy-looking assemblies for HttpClient, etc., fyi)KeyVaultSecret
configuration class whose values contain 3 components: the KeyVault secret URI, and then 2 environment variables which contain the Azure Active Directory Application's client ID and secret. In Azure App Service, a secure deployment environment populates these values, enabling you to commit configuration files to the repo for your e-mail tasks without having to introduce any secrets, DPAPI files, etc.Also happy to discuss internally, my alias is
JWilcox
. We're using this so that we have zero VMs to manage and just a simple Git repo. Good stuff.Appreciate your insight.