File.cs.cshtml cannot become EmbeddedResource

[dsplaisted]

From @davkean on March 5, 2018 22:43

From @abpiskunov on March 2, 2018 6:17

1. Create a new core Web app
2. in File Explorer find some cshtml page (Error.cshtml and rename it to Error.cs.cshtml.
3. In VS change type of Error.cs.cshtml to EmbeddedResource (notice it will be removed from Content in csproj)
4. Build
5. Open assembly manifest and see - no embedded resources
6. When rename file to Error.cshtml , build, assembly manifest does contain EmbeddedResource.

See this issue opened by customer originally : aspnet/Tooling#1066 (comment)

Copied from original issue: dotnet/project-system#3336

Copied from original issue: dotnet/sdk#2024

[dsplaisted]

From @davkean on March 5, 2018 22:43

This would be a build issue, no?

[dsplaisted]

From @davkean on March 5, 2018 22:43

From @abpiskunov on March 2, 2018 16:51

Sounds like that or even could be sdk related, Content item type might somehow interfere with EmbeddedResource.

[dsplaisted]

From @davkean on March 5, 2018 22:43

From @Pilchie on March 2, 2018 19:43

@livarcocc @nguerrera @dsplaisted ?

[dsplaisted]

From @davkean on March 5, 2018 22:43

From @nguerrera on March 2, 2018 20:38

Could be sdk or msbuild. Feel free to move to sdk for next look.

[dsplaisted]

From @davkean on March 5, 2018 22:43

From @dsplaisted on March 2, 2018 20:40

I want to take a look at this, but I suspect it is CPS not understanding how to modify the project to change the item type given the default globs that the project has.

[dsplaisted]

From @davkean on March 5, 2018 22:43

From @abpiskunov on March 2, 2018 21:56

we have a vs feedback bug associated with that 574198. Who should i assign to? Who is doing first investigation here?

[dsplaisted]

From @davkean on March 5, 2018 22:43

From @abpiskunov on March 5, 2018 20:7

Ok i am assigning the bug to Daniel first. Please route it further if it is not yours.

[dsplaisted]

It turns out the issue here is that MSBuild (via the AssignCulture task) thinks that an EmbeddedResource with a name of Error.cs.cshtml is a Culture-specific resource for the cs culture. So ends up going in the satellite assembly for cs.

Related suggestion from @nguerrera: #1454 (comment)

Another approach would be to respect explicit WithCulture metadata as implying that no check is required.

This would let you explicitly turn this off if you don't want it.

[sandrock]

I have the same issue on my side. It looks like the one @rjamesnw posted. Some files get put into a satellite assembly because a part of the file name looks like a culture name.

I would like to the AssignCulture task to skip the file. The related issue #1454 is about forcing the task to assign a culture. I wish to do the opposite: preventing the task from executing.

Is there a workaround available?

[rainersigwald]

I was optimistic about this but it didn't quite work

Incomplete workaround

  <Target Name="WorkaroundMSBuild3064" BeforeTargets="SplitResourcesByCulture">
    <!-- Workaround for https://github.com/Microsoft/msbuild/issues/3064 -->
    <ItemGroup>
      <_ResourcesWithCultureFilename Include="@(EmbeddedResource)" Condition="$([System.String]::Copy('%(Filename)').Contains('.cs'))" />

      <_MixedResourceWithNoCulture Include="@(_ResourcesWithCultureFilename)">
        <WithCulture>false</WithCulture>
      </_MixedResourceWithNoCulture>

      <EmbeddedResource Remove="@(_ResourcesWithCultureFilename)" />
    </ItemGroup>
  </Target>

It doesn't work because the CreateManifestResourceNames target calls CreateCSharpManifestResourceName which does its own independent rediscovery of culture, mangling it to, for example, ManifestResourceName = cs\3064.Views.Home.About.cshtml.

That could be avoided by explicitly specifying a ManifestResourceName, but I can't think of a good way to do the transform automatically--that's why it's done in a task in the first place.

A full solution would need to address the CreateCSharpManifestResourceName culture-discovery problem too.

[benvillalobos]

Related feedback tickets (internal links):

Cannot embedded resource that contains “.ca.” (like something.ca.txt)

I found that when I try to embedded resource with “.ca.” in its name, build fails to do it.


Repro steps:

• Create some folder in project.

• Put there files ca.txt, .ca.txt, somethimg.ca.txt.

• Build project and verify embedded resources.

Embedded resource won't work for some filenames?

If I have an embedded resource file called “light.sms.txt”, then it is not embedded, but if I change it to “light.sms1.txt”, then it is embeded … emm … why?


Here’s what I do…



Create a new Vb.Net WinForm project

Add a text file called light.sms.txt and change build action to Embedded resource

Paste this code in Form1 …


Private Sub Form1_Load(sender As Object, e As EventArgs) Handles MyBase.Load

Static embededResources As String() = GetType(Form1). Assembly.GetManifestResourceNames()

MsgBox(embededResources.Length.ToString)

End Sub


Run the app - the result is 3

Change the embbeded filename to light.sms1.txt

Run the app - the result is now 4


Why doesn’t “light.sms.txt” get embedded?

[ahdung]

same issue, for me, the bad file name is Resources.en.xml or Resources.zh.xml.