Remove MSBuildDebugger feature code #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been diabled in MSBuild 15 and could only be enabled if someone cloned our repo and built locally with /p:MsbuildDebugger=true
rainersigwald
approved these changes
Feb 5, 2018
jeffkl
force-pushed
the
byebyemsbuilddebugger
branch
from
8525808
to
4906e1c
Compare
AndyGerlicher
approved these changes
Feb 5, 2018
jeffkl
added a commit
to jeffkl/msbuild
that referenced
this pull request
Jun 6, 2018
Some stuff I missed in dotnet#2955
jeffkl
added a commit
that referenced
this pull request
Jun 6, 2018
* Remove some more MSBuild debugger code Some stuff I missed in #2955
tmat
pushed a commit
to tmat/msbuild
that referenced
this pull request
Jun 12, 2018
* Remove some more MSBuild debugger code Some stuff I missed in dotnet#2955
|
I've manually added /p:MsbuildDebugger=true to the build script and nothing changed. Grepping shows nothing relating to MsbuildDebugger too. Am I missing something? |
|
@OfekShilon this PR removed the ability to do that, since it hadn't been used or tested in many years. |
|
This is sad.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been diabled in MSBuild 15 and could only be enabled if someone cloned our repo and built locally with /p:MsbuildDebugger=true