Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven | Add Shade plugin configuration to package the driver in an uber-jar #1043

Merged
merged 11 commits into from
May 29, 2019

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Apr 17, 2019

Packages all the dependencies used by the driver.

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #1043 into dev will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1043      +/-   ##
============================================
- Coverage     53.14%   52.91%   -0.24%     
+ Complexity     3172     3142      -30     
============================================
  Files           119      119              
  Lines         28036    27986      -50     
  Branches       4680     4676       -4     
============================================
- Hits          14899    14808      -91     
- Misses        10921    10951      +30     
- Partials       2216     2227      +11
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 65.87% <0%> (-15.89%) 29% <0%> (-13%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (-1%)
...ooglecode/concurrentlinkedhashmap/LinkedDeque.java 26.15% <0%> (-2.31%) 17% <0%> (-3%)
...rosoft/sqlserver/jdbc/SQLServerEncryptionType.java 66.66% <0%> (-2.09%) 5% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 72.85% <0%> (-1.43%) 32% <0%> (-1%)
.../microsoft/sqlserver/jdbc/SQLServerDataColumn.java 77.77% <0%> (-1.39%) 1% <0%> (-6%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 60.87% <0%> (-0.53%) 0% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 46.39% <0%> (-0.49%) 71% <0%> (-2%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.69% <0%> (-0.44%) 90% <0%> (-1%)
...rosoft/sqlserver/jdbc/InternalSpatialDatatype.java 91.3% <0%> (-0.37%) 6% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6beb29a...f2130c3. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to Under Investigation in MSSQL JDBC Apr 18, 2019
@cheenamalhotra cheenamalhotra moved this from Under Investigation to In progress in MSSQL JDBC Apr 18, 2019
lilgreenbird
lilgreenbird previously approved these changes Apr 24, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 25, 2019
cheenamalhotra
cheenamalhotra previously approved these changes Apr 25, 2019
peterbae
peterbae previously approved these changes Apr 26, 2019
@ulvii
Copy link
Contributor

ulvii commented May 11, 2019

PR needs to be updated to reflect JRE12 changes.

@cheenamalhotra cheenamalhotra moved this from In progress to Under Peer Review in MSSQL JDBC May 14, 2019
@cheenamalhotra cheenamalhotra changed the title Add | Fat jar assembly to pom Maven | Add Shade plugin configuration to package the driver in an uber-jar May 28, 2019
@cheenamalhotra cheenamalhotra merged commit 13a5d27 into microsoft:dev May 29, 2019
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs May 29, 2019
@rene-ye rene-ye deleted the FatJar branch October 10, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

6 participants