New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ClassCastException #260

Merged
merged 2 commits into from Apr 24, 2017

Conversation

Projects
None yet
5 participants
@Suraiya-Hameed
Contributor

Suraiya-Hameed commented Apr 21, 2017

No description provided.

@Suraiya-Hameed

This comment has been minimized.

Contributor

Suraiya-Hameed commented Apr 21, 2017

It is the same source code as before, just an extra try/catch, that resulted in formatting a huge chunk of code.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 21, 2017

Codecov Report

Merging #260 into dev will increase coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #260      +/-   ##
============================================
+ Coverage     33.78%   33.86%   +0.07%     
  Complexity     1530     1530              
============================================
  Files           101      101              
  Lines         23584    23590       +6     
  Branches       3867     3867              
============================================
+ Hits           7969     7988      +19     
+ Misses        14045    14030      -15     
- Partials       1570     1572       +2
Flag Coverage Δ Complexity Δ
#JDBC41 33.77% <48.94%> (+0.09%) 1526 <0> (+2) ⬆️
#JDBC42 33.66% <46.84%> (+0.01%) 1523 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 46.1% <50%> (-0.13%) 192 <0> (-2)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 69.69% <0%> (-0.17%) 4% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 34.71% <0%> (-0.07%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 25.17% <0%> (+0.08%) 179% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 27.45% <0%> (+0.44%) 49% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 38.03% <0%> (+0.48%) 0% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 39.05% <0%> (+1.18%) 27% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7228f12...279d051. Read the comment docs.

@Suraiya-Hameed Suraiya-Hameed requested a review from Ahmad-Ibra Apr 21, 2017

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into Ca…
…tchCastException

# Conflicts:
#	src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java

@Suraiya-Hameed Suraiya-Hameed merged commit a73ed0a into Microsoft:dev Apr 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ajlam ajlam removed the PR Under Review label Apr 24, 2017

@Suraiya-Hameed Suraiya-Hameed deleted the Suraiya-Hameed:CatchCastException branch Apr 24, 2017

@v-nisidh v-nisidh added this to the 6.1.7 milestone Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment