Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tvp time 4 fix rtw #317

Merged
merged 3 commits into from
May 29, 2017
Merged

Conversation

xiangyushawn
Copy link
Contributor

for issue #315

…object, which is converted to String later on and precision is removed.
@codecov-io
Copy link

codecov-io commented May 26, 2017

Codecov Report

Merging #317 into RTW_6.2.0 will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##             RTW_6.2.0     #317      +/-   ##
===============================================
- Coverage        37.17%   37.15%   -0.03%     
+ Complexity        1668     1665       -3     
===============================================
  Files              103      103              
  Lines            23661    23663       +2     
  Branches          3917     3918       +1     
===============================================
- Hits              8797     8793       -4     
- Misses           13273    13277       +4     
- Partials          1591     1593       +2
Flag Coverage Δ Complexity Δ
#JDBC41 37.05% <100%> (-0.03%) 1657 <0> (-5)
#JDBC42 37.01% <100%> (-0.03%) 1659 <0> (+1)
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java 45.26% <100%> (+0.45%) 27 <0> (+1) ⬆️
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-2.25%) 16% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.43% <0%> (-0.45%) 56% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 26.86% <0%> (-0.38%) 184% <0%> (-3%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 33.45% <0%> (-0.18%) 89% <0%> (-1%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 43.23% <0%> (+0.08%) 254% <0%> (+2%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.19% <0%> (+0.13%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 48.93% <0%> (+0.14%) 210% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 47.95% <0%> (+0.68%) 61% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fd9c4...f76d872. Read the comment docs.

@@ -112,7 +112,12 @@ boolean isNull() {
Object[] rowData = new Object[colCount];
for (int i = 0; i < colCount; i++) {
try {
rowData[i] = sourceResultSet.getObject(i + 1);
if (java.sql.Types.TIME == sourceResultSet.getMetaData().getColumnType(i + 1)) {
rowData[i] = sourceResultSet.getTimestamp(i + 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. can you just add a comment explaining why getTimestamp is used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added comment for it. Will merge the PR soon.

@xiangyushawn xiangyushawn merged commit d8f677e into microsoft:RTW_6.2.0 May 29, 2017
@xiangyushawn xiangyushawn deleted the TVP-time-4-fix-RTW branch May 29, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants