Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Update Configuration Rules. #541

Merged
merged 4 commits into from
Jan 23, 2018
Merged

Conversation

nsidhaye
Copy link
Contributor

@nsidhaye nsidhaye commented Nov 4, 2017

Generally Maven Project use version plugin to update dependencies. Maven Version gives you way to automate update dependencies.

Most of times we need only stable dependencies. In this PR I am adding maven-version-rules.xml so we can configure which version we need to omit from automatic update.

Ref:
Any Maven Project can use following commands:
mvn versions:display-dependency-updates : Shows newer version of dependencies
mvn versions:use-latest-releases : Update dependencies to latest version
mvn versions:update-properties : Update dependencies by updating properties

@msftclas
Copy link

msftclas commented Nov 4, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #541 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #541      +/-   ##
============================================
- Coverage     46.68%   46.67%   -0.02%     
+ Complexity     2228     2219       -9     
============================================
  Files           108      108              
  Lines         25308    25308              
  Branches       4175     4175              
============================================
- Hits          11815    11812       -3     
- Misses        11463    11465       +2     
- Partials       2030     2031       +1
Flag Coverage Δ Complexity Δ
#JDBC41 46.39% <ø> (-0.05%) 2209 <ø> (-4)
#JDBC42 46.54% <ø> (-0.04%) 2216 <ø> (-8)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 41.57% <0%> (-5.62%) 14% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.86% <0%> (-0.29%) 241% <0%> (-4%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.36% <0%> (-0.11%) 130% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.7% <0%> (+0.19%) 239% <0%> (-1%) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.09% <0%> (+0.23%) 0% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.44% <0%> (+0.42%) 63% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c75147...0691598. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Nov 4, 2017

Codecov Report

Merging #541 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev     #541      +/-   ##
===========================================
+ Coverage     46.5%   46.54%   +0.03%     
- Complexity    2211     2214       +3     
===========================================
  Files          108      108              
  Lines        25320    25320              
  Branches      4177     4177              
===========================================
+ Hits         11775    11785      +10     
+ Misses       11515    11501      -14     
- Partials      2030     2034       +4
Flag Coverage Δ Complexity Δ
#JDBC41 46.35% <ø> (+0.01%) 2206 <ø> (+1) ⬆️
#JDBC42 46.35% <ø> (-0.02%) 2206 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 41.57% <0%> (-3.38%) 14% <0%> (-2%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.76% <0%> (-0.07%) 0% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.79% <0%> (+0.16%) 5% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.11% <0%> (+0.42%) 0% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.33% <0%> (+0.44%) 88% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.92% <0%> (+0.67%) 105% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 76.85% <0%> (+1.65%) 29% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d15edb...e79f964. Read the comment docs.

Copy link
Contributor

@xiangyushawn xiangyushawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nsidhaye Thank you very much for your contribution. I really like the idea of this PR.

A few questions before we merge:

  1. let's delete <!-- try with false --> in pom file?
  2. let's also add pom.xml.versionBackup to .gitignore file?

Maybe we can also add the following comments that you have mentioned to the pom file:

mvn versions:display-dependency-updates : Shows newer version of dependencies
mvn versions:use-latest-releases : Update dependencies to latest version
mvn versions:update-properties : Update dependencies by updating properties

@cheenamalhotra cheenamalhotra added this to the 6.4.0 milestone Jan 23, 2018
@cheenamalhotra
Copy link
Member

Thanks @nsidhaye for the updates.
We are good to merge this PR with our next release.

Thanks for your contribution.

@cheenamalhotra cheenamalhotra merged commit 82b43b0 into microsoft:dev Jan 23, 2018
@nsidhaye nsidhaye deleted the dev branch January 24, 2018 01:08
@cheenamalhotra cheenamalhotra removed the request for review from peterbae February 15, 2018 18:57
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants