Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql timeout excepetion #641

Merged
merged 24 commits into from
Mar 8, 2018
Merged

Sql timeout excepetion #641

merged 24 commits into from
Mar 8, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Mar 1, 2018

No description provided.

rene-ye and others added 7 commits February 2, 2018 15:46
To help debug an irreproducable/random mismatch error if it occurs in the future.
added an error code to determine if the query has timed out. Statement will attempt to catch a timeout error, and throw java.sql.TimeoutException if it does.
more readable, and shorter
@rene-ye rene-ye added this to the 6.5.0 milestone Mar 1, 2018
changed test to expect the new SQLTimeoutException
@codecov-io
Copy link

codecov-io commented Mar 1, 2018

Codecov Report

Merging #641 into dev will increase coverage by <.01%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #641      +/-   ##
============================================
+ Coverage     46.47%   46.47%   +<.01%     
+ Complexity     2228     2227       -1     
============================================
  Files           109      109              
  Lines         25439    25449      +10     
  Branches       4190     4193       +3     
============================================
+ Hits          11822    11828       +6     
  Misses        11574    11574              
- Partials       2043     2047       +4
Flag Coverage Δ Complexity Δ
#JDBC42 46.34% <53.84%> (-0.04%) 2224 <0> (-1)
#JDBC43 46.35% <53.84%> (-0.05%) 2219 <0> (-8)
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 36.03% <ø> (ø) 55 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.53% <ø> (+0.24%) 155 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.23% <100%> (+0.37%) 30 <0> (+1) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.61% <100%> (+0.16%) 132 <0> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.54% <0%> (-0.86%) 42% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.91% <0%> (-0.44%) 88% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.54% <0%> (-0.07%) 240% <0%> (+1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.06% <0%> (-0.04%) 0% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0df377...6573694. Read the comment docs.

@rene-ye rene-ye modified the milestone: 6.5.0 Mar 1, 2018
rene-ye and others added 3 commits March 2, 2018 13:58
less catching, more throwing.
Have the exception handle setting its own properties instead of setting it in IOBuffer where it's out of place.
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Mar 3, 2018
rene-ye and others added 5 commits March 5, 2018 11:59
changed tests to expect SQLException instead of SQLServerException.
reverted typed changes due to possibility of breaking customer applications.
rene-ye and others added 3 commits March 6, 2018 15:02
Handles a case where strings would be translated and the error would not be thrown
fixed an error where the script replaced SQLServerException would produce "throw SQLException, SQLException"
fixed comments that were incorrectly modified
@rene-ye rene-ye merged commit 79b3c94 into microsoft:dev Mar 8, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Mar 8, 2018
@rene-ye rene-ye deleted the SQLTimeoutExcepetion branch March 8, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants