Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spatial datatypes #642

Merged
merged 22 commits into from
Mar 8, 2018
Merged

Spatial datatypes #642

merged 22 commits into from
Mar 8, 2018

Conversation

peterbae
Copy link
Contributor

@peterbae peterbae commented Mar 5, 2018 •
edited
Loading

All tests passed.

peterbae and others added 15 commits September 27, 2017 14:23
@codecov-io
Copy link

codecov-io commented Mar 5, 2018 •
edited
Loading

Codecov Report

Merging #642 into dev will increase coverage by 1.71%.
The diff coverage is 83.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #642      +/-   ##
============================================
+ Coverage     46.45%   48.17%   +1.71%     
- Complexity     2228     2581     +353     
============================================
  Files           109      113       +4     
  Lines         25449    26574    +1125     
  Branches       4193     4429     +236     
============================================
+ Hits          11822    12801     +979     
- Misses        11588    11649      +61     
- Partials       2039     2124      +85
Flag Coverage Δ Complexity Δ
#JDBC42 48.07% <83.14%> (+1.67%) 2573 <342> (+347) ⬆️
#JDBC43 48.11% <83.14%> (+1.74%) 2581 <342> (+357) ⬆️
Impacted Files Coverage Δ Complexity Δ
src/main/java/microsoft/sql/Types.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.76% <100%> (+0.52%) 63 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.08% <100%> (+1.16%) 108 <0> (+4) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.41% <100%> (+0.75%) 0 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 78.01% <100%> (+0.22%) 5 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.49% <50%> (+0.61%) 249 <2> (+7) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/Geography.java 69.53% <69.53%> (ø) 33 <33> (?)
...in/java/com/microsoft/sqlserver/jdbc/Geometry.java 71.09% <71.09%> (ø) 33 <33> (?)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.85% <83.33%> (+0.31%) 157 <2> (+2) ⬆️
...osoft/sqlserver/jdbc/SQLServerSpatialDatatype.java 87.43% <87.43%> (ø) 266 <266> (?)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b3c94...66d3da9. Read the comment docs.

cheenamalhotra
cheenamalhotra reviewed Mar 6, 2018
View reviewed changes
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java Outdated

byte[] geomWKB = Hex.decodeHex("0A00000002001700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000F03F00000000000008400000000000000840000000000000144000000000000010400000000000001C400000000000001C400000000000000840000000000000F03F00000000000008400000000000000000C7D79E59127037C00000000000000000C7D79E591270374000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C00000000000000000C7D79E59127037C00000000000001C400000000000001C400000000000000000C7D79E5912703740000000000000204000000000000020400000000000002040000000000000204000000000008046C0C7D79E591270374000000000008056C0C7D79E591270374000000000008056C0C7D79E59127037C000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C004000000010000000002040000000309000000030D00000001000000FFFFFFFF000000000A080000000203020003010203".toCharArray());
byte[] geogWKB = Hex.decodeHex("E6100000020017000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000840000000000000F03F000000000000144000000000000008400000000000001C40000000000000104000000000000008400000000000001C400000000000000840000000000000F03FC7D79E59127037C00000000000000000C7D79E59127037400000000000000000C7D79E59127037C000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C000000000000000000000000000001C400000000000001C40C7D79E591270374000000000000000000000000000002040000000000000204000000000000020400000000000002040C7D79E591270374000000000008046C0C7D79E591270374000000000008056C0C7D79E59127037C000000000008056C0C7D79E59127037C000000000008046C0C7D79E59127037C0000000000000000004000000010000000002040000000309000000030D00000001000000FFFFFFFF000000000A080000000203020003010203".toCharArray());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to hard-code and compare byte arrays for all above tests.. please modify tests to compare with database stored values instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discarding change as coverage found in WKT tests

cheenamalhotra
cheenamalhotra reviewed Mar 6, 2018
View reviewed changes
src/main/java/com/microsoft/sqlserver/jdbc/Geometry.java Outdated
interpretSerializationPropBytes();

readNumberOfPoints();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unwanted spaces

@rene-ye rene-ye added this to the 6.5.0 milestone Mar 6, 2018
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Mar 6, 2018
@rene-ye rene-ye self-requested a review March 8, 2018 19:05
@peterbae peterbae merged commit 957da5d into dev Mar 8, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Mar 8, 2018
@cheenamalhotra cheenamalhotra deleted the Spatial_Datatypes branch October 1, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@rene-ye rene-ye rene-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterbae @codecov-io @rene-ye @cheenamalhotra