Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance degradation while maintaining JDBC compliance with results from sp_fkeys #677

Merged
merged 8 commits into from
May 3, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Apr 12, 2018

Addresses issue #665. Affects getImportedKeys, getExportedKeys, and getCrossReference. Uses a single callable statement to create a temporary variable and edits UPDATE_RULE/DELETE_RULE before returning. Also changes some column names to conform to JDBC specs. Tests appear to be flawed. Changed temporarily and will revisit in the future.

rene-ye and others added 4 commits February 2, 2018 15:46
To help debug an irreproducable/random mismatch error if it occurs in the future.
Affects getImportedKeys, getExportedKeys, and getCrossReference. Uses a single callable statement to create a temporary variable and edits UPDATE_RULE/DELETE_RULE before returning. Also changes the names of some of the columns to conform to JDBC specs.
@rene-ye rene-ye changed the title Fix for #665 - Improved performance degradation while maintaining JDBC compliance with results from sp_fkeys Improved performance degradation while maintaining JDBC compliance with results from sp_fkeys Apr 12, 2018
@rene-ye rene-ye added this to the 6.5.2 milestone Apr 12, 2018
@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #677 into dev will decrease coverage by 0.15%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #677      +/-   ##
============================================
- Coverage     48.22%   48.07%   -0.16%     
+ Complexity     2583     2579       -4     
============================================
  Files           113      113              
  Lines         26626    26572      -54     
  Branches       4449     4450       +1     
============================================
- Hits          12840    12774      -66     
- Misses        11644    11658      +14     
+ Partials       2142     2140       -2
Flag Coverage Δ Complexity Δ
#JDBC42 47.99% <80%> (-0.14%) 2574 <8> (-4)
#JDBC43 47.94% <80%> (-0.08%) 2575 <8> (+2)
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 32.42% <80%> (-3.61%) 58 <8> (+3)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.54% <0%> (-0.65%) 42% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.91% <0%> (-0.44%) 88% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.78% <0%> (-0.36%) 242% <0%> (-3%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.85% <0%> (-0.17%) 4% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.68% <0%> (-0.17%) 157% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.71% <0%> (-0.08%) 288% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.41% <0%> (+0.05%) 0% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.13% <0%> (+0.06%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914008f...7ee0e95. Read the comment docs.

@peterbae peterbae self-requested a review May 1, 2018 23:46
@rene-ye rene-ye requested a review from ulvii May 2, 2018 22:28
@rene-ye rene-ye removed the request for review from ulvii May 2, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants