Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scope of unwanted Public APIs + Code Format #757

Merged
merged 5 commits into from
Jul 28, 2018

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #757 into dev will decrease coverage by 0.13%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #757      +/-   ##
============================================
- Coverage     48.21%   48.08%   -0.14%     
+ Complexity     2781     2774       -7     
============================================
  Files           116      116              
  Lines         27853    27854       +1     
  Branches       4636     4636              
============================================
- Hits          13430    13393      -37     
- Misses        12201    12245      +44     
+ Partials       2222     2216       -6
Flag Coverage Δ Complexity Δ
#JDBC42 47.6% <57.14%> (-0.15%) 2731 <0> (-10)
#JDBC43 48.01% <57.14%> (+0.03%) 2770 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
.../java/com/microsoft/sqlserver/jdbc/SqlVariant.java 88.33% <ø> (ø) 13 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerJdbc43.java 25% <ø> (ø) 0 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.6% <ø> (-0.12%) 263 <0> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.27% <ø> (ø) 31 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 80.22% <100%> (+0.04%) 25 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.72% <33.33%> (ø) 64 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 52.23% <50%> (ø) 217 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 42.85% <0%> (-5.5%) 15% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.82% <0%> (-0.66%) 87% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.31% <0%> (-0.5%) 0% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4558e...4919714. Read the comment docs.

rene-ye
rene-ye previously approved these changes Jul 23, 2018
@cheenamalhotra cheenamalhotra changed the title Change scope of unwanted Public APIs Change scope of unwanted Public APIs + Code Format Jul 23, 2018
ulvii
ulvii previously approved these changes Jul 23, 2018
rene-ye
rene-ye previously approved these changes Jul 23, 2018
peterbae
peterbae previously approved these changes Jul 23, 2018
@cheenamalhotra cheenamalhotra added this to the 7.0.0 milestone Jul 24, 2018
lilgreenbird
lilgreenbird previously approved these changes Jul 26, 2018
peterbae
peterbae previously approved these changes Jul 26, 2018
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Jul 27, 2018
lilgreenbird
lilgreenbird previously approved these changes Jul 27, 2018
@cheenamalhotra cheenamalhotra merged commit 970f21a into microsoft:dev Jul 28, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Jul 28, 2018
@cheenamalhotra cheenamalhotra deleted the API_fixes branch July 28, 2018 03:27
cheenamalhotra added a commit that referenced this pull request Jul 31, 2018
* Update Snapshot for upcoming RTW release v7.0.0

* Change order of logic for checking the condition for using Bulk Copy API (#736)

Fix | Change order of logic for checking the condition for using Bulk Copy API (#736)

* Update CHANGELOG.md

* Merge pull request #732 from cheenamalhotra/module (Export driver in automatic module)

Introduce Automatic Module Name in POM.

* Update CHANGELOG.md

* Change Sha1HashKey to CityHash128Key for generating PreparedStatement handle and metadata cache keys (#717)

* Change Sha1HashKey to CityHash128Key

* Formatted code

* Prepared statement performance fixes

1) Further speedups to prepared statement hashing

2) Caching of '?' chararacter positiobs in prepared statements to speed parameter substitution

* String compare for hash keys
added missing line for bulkcopy tests.

* comment change

* Move CityHash class to a separate file

* spacings fixes
cleaner code & logic

* Add | Adding useBulkCopyForBatchInsert property to Request Boundary methods (#739)

* Apply the collation name change to UTF8SupportTest

* Package changes for CityHash with license information (#740)

* Reformatted Code + Updated formatter (#742)

* Reformatted Code + Updated formatter

* Fix policheck issue with 'Country' keyword (#745)

* Adding a new test for beginRequest()/endRequest() (#746)

* Add | Adding a new test to notify the developers to consider beginRequest()/endRequest() when adding a new Connection API

* Fix | Fixes for issues reported by static analysis tools (SonarQube + Fortify) (#747)

* handle buffer reading

for invalid buffer input by user

* Revert "handle buffer reading"

This reverts commit 11e2bf4.

* updated javadocs (#754)

* fixed some typos in javadocs (#760)

* API and JavaDoc changes for Spatial Datatypes (#752)

Add | API and JavaDoc changes for Spatial Datatypes (#752)

* Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

fix | Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

* Formatting | Change scope of unwanted Public APIs + Code Format (#757)

* Fix unwanted Public APIs.
* Updated formatter to add new line to EOF + formatted project

* Release | Release 7.0 changelog and version update (#748)

* Updated Changelog + release version changes

* Changelog entry updated as per review.

* Updated changelog for new changes

* Terminology update: request boundary declaration APIs

* Trigger Appveyor

* Update Samples and add new samples for new features (#761)

* Update Samples and add new Samples for new features

* Update samples from Peter

* Updated JavaDocs

* Switch to block comment

* Update License copyright (#767)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

6 participants