Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setUseBulkCopyForBatchInsert() to Request Boundary methods #739

Merged
merged 1 commit into from Jul 9, 2018

Conversation

ulvii
Copy link
Contributor

@ulvii ulvii commented Jul 9, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #739 into dev will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #739      +/-   ##
============================================
+ Coverage     48.52%   48.58%   +0.06%     
  Complexity     2773     2773              
============================================
  Files           116      116              
  Lines         27342    27345       +3     
  Branches       4562     4563       +1     
============================================
+ Hits          13268    13286      +18     
+ Misses        11909    11885      -24     
- Partials       2165     2174       +9
Flag Coverage Δ Complexity Δ
#JDBC42 48.12% <0%> (+0.09%) 2732 <0> (+6) ⬆️
#JDBC43 48.35% <100%> (-0.04%) 2759 <0> (-7)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.66% <100%> (+0.05%) 334 <0> (+1) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.79% <0%> (-0.22%) 43% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 53.35% <0%> (-0.07%) 262% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.41% <0%> (ø) 108% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.36% <0%> (+0.17%) 0% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.76% <0%> (+0.2%) 64% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.5% <0%> (+0.39%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (+1.12%) 16% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2cf217...54994c2. Read the comment docs.

@ulvii ulvii merged commit 78c6a19 into microsoft:dev Jul 9, 2018
@ulvii ulvii deleted the RequestBoundaryFix branch July 9, 2018 23:16
@cheenamalhotra cheenamalhotra added this to the 7.0.0 milestone Jul 10, 2018
cheenamalhotra added a commit that referenced this pull request Jul 31, 2018
* Update Snapshot for upcoming RTW release v7.0.0

* Change order of logic for checking the condition for using Bulk Copy API (#736)

Fix | Change order of logic for checking the condition for using Bulk Copy API (#736)

* Update CHANGELOG.md

* Merge pull request #732 from cheenamalhotra/module (Export driver in automatic module)

Introduce Automatic Module Name in POM.

* Update CHANGELOG.md

* Change Sha1HashKey to CityHash128Key for generating PreparedStatement handle and metadata cache keys (#717)

* Change Sha1HashKey to CityHash128Key

* Formatted code

* Prepared statement performance fixes

1) Further speedups to prepared statement hashing

2) Caching of '?' chararacter positiobs in prepared statements to speed parameter substitution

* String compare for hash keys
added missing line for bulkcopy tests.

* comment change

* Move CityHash class to a separate file

* spacings fixes
cleaner code & logic

* Add | Adding useBulkCopyForBatchInsert property to Request Boundary methods (#739)

* Apply the collation name change to UTF8SupportTest

* Package changes for CityHash with license information (#740)

* Reformatted Code + Updated formatter (#742)

* Reformatted Code + Updated formatter

* Fix policheck issue with 'Country' keyword (#745)

* Adding a new test for beginRequest()/endRequest() (#746)

* Add | Adding a new test to notify the developers to consider beginRequest()/endRequest() when adding a new Connection API

* Fix | Fixes for issues reported by static analysis tools (SonarQube + Fortify) (#747)

* handle buffer reading

for invalid buffer input by user

* Revert "handle buffer reading"

This reverts commit 11e2bf4.

* updated javadocs (#754)

* fixed some typos in javadocs (#760)

* API and JavaDoc changes for Spatial Datatypes (#752)

Add | API and JavaDoc changes for Spatial Datatypes (#752)

* Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

fix | Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

* Formatting | Change scope of unwanted Public APIs + Code Format (#757)

* Fix unwanted Public APIs.
* Updated formatter to add new line to EOF + formatted project

* Release | Release 7.0 changelog and version update (#748)

* Updated Changelog + release version changes

* Changelog entry updated as per review.

* Updated changelog for new changes

* Terminology update: request boundary declaration APIs

* Trigger Appveyor

* Update Samples and add new samples for new features (#761)

* Update Samples and add new Samples for new features

* Update samples from Peter

* Updated JavaDocs

* Switch to block comment

* Update License copyright (#767)
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants