Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded names in junit tests #809

Merged
merged 37 commits into from
Oct 5, 2018

Conversation

lilgreenbird
Copy link
Member

Cleanup junit tests to remove hardcoded names

@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Sep 28, 2018
@codecov-io
Copy link

codecov-io commented Sep 29, 2018

Codecov Report

Merging #809 into dev will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #809      +/-   ##
============================================
- Coverage     48.67%   48.37%   -0.31%     
+ Complexity     2814     2784      -30     
============================================
  Files           116      116              
  Lines         27878    27878              
  Branches       4651     4651              
============================================
- Hits          13571    13486      -85     
- Misses        12171    12174       +3     
- Partials       2136     2218      +82
Flag Coverage Δ Complexity Δ
#JDBC42 47.89% <ø> (-0.3%) 2742 <ø> (-29)
#JDBC43 48.32% <ø> (+0.01%) 2783 <ø> (-1) ⬇️
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.58% <0%> (-1.98%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.44% <0%> (-1.51%) 31% <0%> (-2%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-1.08%) 89% <0%> (-4%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.1% <0%> (-0.87%) 0% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 47.91% <0%> (-0.54%) 334% <0%> (-14%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.77% <0%> (-0.46%) 212% <0%> (-4%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.51% <0%> (-0.29%) 135% <0%> (-6%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.28% <0%> (-0.2%) 4% <0%> (-1%)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 33.33% <0%> (+0.11%) 62% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (+0.12%) 263% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14890cd...6495313. Read the comment docs.

@lilgreenbird lilgreenbird changed the title Remove hardcoded names Remove hardcoded names in junit tests Oct 1, 2018
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Oct 2, 2018
@lilgreenbird lilgreenbird merged commit c50d817 into microsoft:dev Oct 5, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants