Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for intermittent failures in JUnit tests - LobsTest #827

Merged
merged 6 commits into from
Oct 26, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Oct 9, 2018

removing sql error code check as it's not used consistently in the driver

@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #827 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #827      +/-   ##
============================================
+ Coverage     48.58%   48.62%   +0.03%     
- Complexity     2794     2797       +3     
============================================
  Files           116      116              
  Lines         27879    27879              
  Branches       4651     4651              
============================================
+ Hits          13545    13556      +11     
+ Misses        12124    12116       -8     
+ Partials       2210     2207       -3
Flag Coverage Δ Complexity Δ
#JDBC42 48.08% <ø> (+0.09%) 2746 <ø> (ø) ⬇️
#JDBC43 48.55% <ø> (+0.01%) 2794 <ø> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.85% <0%> (-0.88%) 107% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (+0.12%) 264% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.35% <0%> (+0.13%) 0% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.72% <0%> (+0.2%) 64% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.11% <0%> (+0.34%) 260% <0%> (+4%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (+1.09%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e521780...9cc7d4b. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Oct 12, 2018
lilgreenbird
lilgreenbird previously approved these changes Oct 13, 2018
@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 18, 2018
peterbae
peterbae previously approved these changes Oct 22, 2018
@cheenamalhotra cheenamalhotra changed the title resolving an intermittent error in junit tests Fix for intermittent failures in JUnit tests - LobsTest Oct 23, 2018
cheenamalhotra
cheenamalhotra previously approved these changes Oct 24, 2018
@rene-ye rene-ye merged commit 7a59625 into microsoft:dev Oct 26, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Oct 26, 2018
@rene-ye rene-ye deleted the intermitent_junit_lobs branch October 10, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

6 participants