Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Active Directory MSI Authentication support #838

Merged
merged 27 commits into from
Dec 25, 2018

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Oct 19, 2018

Introduces:

  • Support for Azure AD MSI Authentication with:
    • System Assigned Managed Identity
    • User Assigned Managed Identity
  • New Authentication Mode: "ActiveDirectoryMSI"
  • New Connection Property:
    msiClientId: Accepts Client Id for "User Assigned Managed Identity" to retrieve Access Token

Fixes:

  • Issues with Refresh Token creating new Connection every 15 mins

@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 19, 2018
@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #838 into dev will decrease coverage by 0.32%.
The diff coverage is 9.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #838      +/-   ##
============================================
- Coverage     48.79%   48.46%   -0.33%     
+ Complexity     2824     2817       -7     
============================================
  Files           118      118              
  Lines         27877    28011     +134     
  Branches       4642     4673      +31     
============================================
- Hits          13602    13575      -27     
- Misses        12086    12248     +162     
+ Partials       2189     2188       -1
Flag Coverage Δ Complexity Δ
#JDBC42 47.99% <9.25%> (-0.34%) 2777 <8> (-6)
#JDBC43 48.33% <9.25%> (-0.36%) 2809 <8> (-9)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/AuthenticationJNI.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.56% <ø> (-0.44%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.12% <ø> (-0.3%) 89 <0> (-1)
.../com/microsoft/sqlserver/jdbc/SqlFedAuthToken.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.12% <0%> (-0.45%) 66 <0> (ø)
...microsoft/sqlserver/jdbc/SQLServerADAL4JUtils.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.3% <3.84%> (-1.8%) 335 <7> (ø)
...soft/sqlserver/jdbc/SQLServerPooledConnection.java 68.42% <50%> (+0.33%) 17 <1> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 80.04% <75%> (-0.19%) 25 <0> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02467eb...0271ea2. Read the comment docs.

@cheenamalhotra cheenamalhotra removed this from the 7.1.2 milestone Oct 23, 2018
@peterbae
Copy link
Contributor

peterbae commented Nov 5, 2018

Uploading the jre 8 jar created from this PR.

mssql-jdbc-msi-support-PR838.jre8.jar.zip

@ulvii ulvii added this to the 7.1.4 milestone Dec 3, 2018
ulvii
ulvii previously approved these changes Dec 22, 2018
lilgreenbird
lilgreenbird previously approved these changes Dec 24, 2018
@cheenamalhotra cheenamalhotra merged commit 3f9635a into microsoft:dev Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants