-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Active Directory MSI Authentication support #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #838 +/- ##
============================================
- Coverage 48.79% 48.46% -0.33%
+ Complexity 2824 2817 -7
============================================
Files 118 118
Lines 27877 28011 +134
Branches 4642 4673 +31
============================================
- Hits 13602 13575 -27
- Misses 12086 12248 +162
+ Partials 2189 2188 -1
Continue to review full report at Codecov.
|
peterbae
reviewed
Oct 22, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java
Outdated
Show resolved
Hide resolved
peterbae
reviewed
Oct 22, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
peterbae
reviewed
Oct 22, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
peterbae
reviewed
Oct 23, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerADAL4JUtils.java
Outdated
Show resolved
Hide resolved
Uploading the jre 8 jar created from this PR. |
rene-ye
reviewed
Dec 19, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Dec 19, 2018
ulvii
reviewed
Dec 19, 2018
ulvii
reviewed
Dec 19, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Dec 21, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java
Outdated
Show resolved
Hide resolved
ulvii
previously approved these changes
Dec 22, 2018
lilgreenbird
previously approved these changes
Dec 24, 2018
0271ea2
lilgreenbird
approved these changes
Dec 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
msiClientId: Accepts Client Id for "User Assigned Managed Identity" to retrieve Access Token
Fixes: