Implement missing MetaData #isWrapperFor methods #94
Conversation
|
Thank you @marschall for submitting a pr. The changes in the three source code files are good. But we updated the tests to use the new framework, that's why a conflict exists in your pr now. |
|
I committed the tests with the new test framework, the test that's failing is |
|
@marschall thank you. You are correct, that build fail was not because of your changes. The next commits you make should not cause any failures. |
|
|
||
| assertSame(rs, rs.unwrap(ResultSet.class)); | ||
| assertSame(rs, rs.unwrap(ISQLServerResultSet.class)); | ||
| } |
There was a problem hiding this comment.
Please drop the tables before the test finishes. It will throw exception that object already exists.
There was a problem hiding this comment.
That's right, ParameterMetaDataTest had the same issue.
The driver currently implements all #unwrap methods but some of the matching #isWrapperFor methods are missing. This is caused by the fix for #12 which should also have included the #isWrapperFor methods. - implement DatabaseMetaData#isWrapperFor - implement ParameterMetaData#isWrapperFor - implement ResultSetMetaData#isWrapperFor
|
Thank you for your contribution @marschall |
The driver currently implements all #unwrap methods but some of the
matching #isWrapperFor methods are missing. This is caused by the fix
for #12 which should also have included the #isWrapperFor methods.