Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dimensions and font size to improve appearance of general properties page in high dpi #1453

Merged
merged 3 commits into from Feb 9, 2017

Conversation

anubmat
Copy link
Contributor

@anubmat anubmat commented Jan 3, 2017

Bug #1452 : General Properties page is hard to read in high dpi

@msftclas
Copy link

msftclas commented Jan 3, 2017

Hi @anubmat, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@paulvanbrenk
Copy link
Contributor

Can you add a screenshot on how this looks after your changes?

@anubmat
Copy link
Contributor Author

anubmat commented Feb 4, 2017

This is how node project property page will look. In both cases text is big enough to read (looks small here). It will begin to look a little worse in Normal resolution, but will become readable in high-dpi. I adjusted locations and sizes a/c to high dpi. I think an improvement would be to have a table layout like TS, and make autoscalable columns.

Normal (1920X1080):
image

High dpi:
image

@paulvanbrenk
Copy link
Contributor

Thanks, that looks pretty good.

@anubmat
Copy link
Contributor Author

anubmat commented Feb 9, 2017

@RyanCavanaugh , can you help me check this in?

@RyanCavanaugh RyanCavanaugh merged commit 101ed9b into microsoft:master Feb 9, 2017
@RyanCavanaugh
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants