Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot enable libmi logging on psrp client using tag v1.4.0-6 #438

Closed
dantraMSFT opened this issue Nov 11, 2017 · 1 comment
Closed

Cannot enable libmi logging on psrp client using tag v1.4.0-6 #438

dantraMSFT opened this issue Nov 11, 2017 · 1 comment

Comments

@dantraMSFT
Copy link
Contributor

I've been successful at enabling PSRP client logging to shellclient.log, I cannot get the lower layer to log to miclient.log.

This is a client-only installation using PowerShell with libmi and libpsrpclient from tag v1.4.0-6.

It makes it almost impossible to diagnose connectivity failures. This is impacting PowerShell issue PowerShell/PowerShell#5130 which currently appear to never return from the connection request.
@dantraMSFT
Copy link
Contributor Author

After a little digging, this is a regression caused by this change: 3f21173#diff-5c17155d212b48e7c302ca0508a9659d

The PathsID enum in paths.h is out of sync with the _paths[] in paths.c. The "credsdir" entry appears to be unneeded and the order of ID_CLIENTCONFIGFILE and ID_KRB5_KEYTABPATH are not defined in the same order as they appear in paths.c:_paths[]

@dantraMSFT dantraMSFT mentioned this issue Nov 13, 2017
Closed
yakman2020 pushed a commit that referenced this issue Nov 13, 2017
Resolve problems with psrp issues #437,#438,#439
f6c1951
yakman2020 pushed a commit that referenced this issue Nov 13, 2017
Resolve problems with psrp issues #437,#438,#439
271f3cb 
Issues fixed:
yakman2020 pushed a commit that referenced this issue Nov 13, 2017
Resolve problems with psrp issues #437,#438,#439
1bf447e 
Issues fixed:
  Issue #437: Buffer overrun in httpclient.c - _CreateHttpHeader
  Issue #438: Cannot enable libmi logging on psrp client using tag v1.4.0-6
  Issue #439: httpclient.c:_RequestCallbackWrite does not handle partial sends.
jeffaco pushed a commit that referenced this issue Nov 14, 2017
@jeffaco
Resolve problems with psrp issues #437,#438,#439
1770fbe 
Issues fixed:

Issue #437: Buffer overrun in httpclient.c - _CreateHttpHeader
Issue #438: Cannot enable libmi logging on psrp client using v1.4.0-6
Issue #439: httpclient.c:_RequestCallbackWrite not handling partial sends.
@dantraMSFT dantraMSFT mentioned this issue Nov 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dantraMSFT @paulcallen