remove minus sign from version

[vitlav]

Please, do not use minus sign (dash) in version, it breaks build to rpm package, where dash is not supported in version.

[JumpingYang001]

@vitlav, can you explain more clearly?
do you mean "omi-MAJOR.MINOR.PATCH-BUILD.ssl_110.ulinux.x64.rpm" contains dash will break something when building from source code?
our build server works fine for building this kind of formats.

[paulcallen]

IF I remember correctly:
MAJOR.MINOR.PATCH-BUILD
RPM only supports first 3 when uploading to the package server.
Therefore we should always rev PATCH so that updates can be detected through package manager.
We have discussed this internally before but may have been forgotten.

[vitlav]

Hi, I assume that rpm uses format "name-version-release" for package names.
Let's split your example line:
name=omi
version=MAJOR.MINOR.PATCH
release=BUILD.ssl_110.ulinux
Note that BUILD is a property of binary build.

You are right if you use the same sources for different BUILDs of the same version.

But I have just checked diff between 1.4.2-3 and 1.4.2.4, there are many changes in server code, e. g.

diff -r -u omi-1.4.2-3/Unix/server/server.c omi-1.4.2-4/Unix/server/server.c
--- omi-1.4.2-3/Unix/server/server.c 2018-05-04 22:49:15.000000000 +0300
+++ omi-1.4.2-4/Unix/server/server.c 2018-06-14 00:21:55.000000000 +0300
@@ -77,6 +77,7 @@

if(socketpair(AF_UNIX, SOCK_STREAM, 0, s) != 0)
{

• trace_Failed_Socket_Pair();
  err(ZT("failed to create unix-domain socket pair"));
  }

[JumpingYang001]

@palladia @paulcallen so we should rev PATCH in the future release, and add this attention in our generating release packages doc (if have).

[JumpingYang001]

we don't want to confuse exist customers, so we won't change the number behavior at present.

[vitlav]

You are talking about release numbering for binaries. Can you just keep sources (C source code) untouched when make next binary build in release? In other words, increment PATCH with every source code change?

[JumpingYang001]

@vitlav we'll make the changes in the future but not at present, you can check with our lead @palladia .

[palladia]

Next version of omi will be 1.5.0. Build numbers will only be used internally.

[vitlav]

Latest releases have build number again:
v1.6.8-0 …
v1.6.7-0 …
v1.6.6-0 …

[JumpingYang001]

@vitlav -0 is -BUILD in MAJOR.MINOR.PATCH-BUILD, it keeps 0 and PATCH increase number since v1.5.0, I think that make sense.
you can check the packages: https://github.com/microsoft/omi/releases/tag/v1.5.0