Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Add ELU activation function #101

Merged
merged 3 commits into from
Mar 12, 2019
Merged

Add ELU activation function #101

merged 3 commits into from
Mar 12, 2019

Conversation

NTT123
Copy link
Contributor

@NTT123 NTT123 commented Mar 5, 2019

Resolve the issue #96 .

hariharans29
hariharans29 reviewed Mar 10, 2019
View reviewed changes
Copy link
Member

@hariharans29 hariharans29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fs-eire - I am generally okay with this change, your comments if any please.

lib/backends/webgl/ops/elu.ts Show resolved Hide resolved
fs-eire
fs-eire approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@fs-eire fs-eire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Thanks for help figuring out the potential issue that may break the shader compiling. This problem may already sit in some previous implementation.

@hariharans29 hariharans29 merged commit 3439e56 into microsoft:master Mar 12, 2019
@NTT123 NTT123 deleted the add_elu_ops branch March 13, 2019 04:54
@hariharans29 hariharans29 mentioned this pull request Mar 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hariharans29 hariharans29 hariharans29 left review comments

@fs-eire fs-eire fs-eire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NTT123 @fs-eire @hariharans29