This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Adding a description of our supported platforms. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
suggested changes
Dec 4, 2018
README.md
Outdated
| @@ -11,6 +11,8 @@ With ONNX.js, web developers can score pre-trained ONNX models directly on brows | |||
|
|
|||
| ONNX.js can run on both CPU and GPU. For running on CPU, [WebAssembly](https://developer.mozilla.org/en-US/docs/WebAssembly) is adopted to execute model at near-native speed. Furthermore, ONNX.js utilizes [Web Workers](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Using_web_workers) to provide a "multi-threaded" environment to parallelize data processing. Empirical evaluation shows very promising performance gains on CPU by taking full advantage of WebAssembly and Web Workers. For running on GPUs, a popular standard for accessing GPU capabilities - WebGL is adopted. ONNX.js has further adopted several novel optimization techniques for reducing data transfer between CPU and GPU, as well as some techniques to reduce GPU processing cycles to further push the performance to the maximum. | |||
|
|
|||
| See [here](#Platforms-supported) for a list of platforms ONNX.js supports. | |||
There was a problem hiding this comment.
Let's make this line a 'quick link' line
See [compatibility], [operators supported]
There was a problem hiding this comment.
link of [Operators Supported] is broken
hariharans29
reviewed
Dec 4, 2018
fs-eire
reviewed
Dec 6, 2018
README.md
Outdated
| | OS/Browser | Chrome | Edge | FireFox | Safari | Opera | Electron | Node.js | | ||
| |:----------:|:------:|:----:|:-------:|:------:|:-----:|:-----:|:-----:| | ||
| | Windows 10 | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | - | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | | ||
| | macOS | :heavy_check_mark: | - | :heavy_check_mark: | Coming soon | :heavy_check_mark: | Coming soon | Coming soon | |
There was a problem hiding this comment.
should take a look at Node.js on macOS.
I think this should already supported
fs-eire
reviewed
Dec 6, 2018
README.md
Outdated
| | Android | :heavy_check_mark: | :heavy_check_mark: | Coming soon | - | :heavy_check_mark: | | ||
|
|
||
| ### Operators | ||
| ONNX.js currently supports most operators in **`ai.onnx`** operator set v7 (opset v7). See [operators.md](./docs/operators.md) for a complete, detailed list of which ONNX operators are supported by the 3 available builtin backends (cpu, wasm, and webgl). |
There was a problem hiding this comment.
add links to operator sets ai.onnx and ai.onnx.ml
https://github.com/onnx/onnx/blob/master/docs/Operators.md
https://github.com/onnx/onnx/blob/master/docs/Operators-ml.md
fs-eire
reviewed
Dec 6, 2018
docs/operators.md
Outdated
| @@ -1,63 +1,63 @@ | |||
| The following table lists the ONNX operators supported by each of the available backends. | |||
| The following table lists the **ai.onnx** operators supported by each of the available backends. | |||
There was a problem hiding this comment.
add links to operator set ai.onnx
fs-eire
reviewed
Dec 6, 2018
fs-eire
approved these changes
Dec 6, 2018
hariharans29
reviewed
Dec 7, 2018
docs/operators.md
Outdated
| @@ -1,64 +1,64 @@ | |||
| The following table lists the ONNX operators supported by each of the available backends. | |||
| The following table lists the [ai.onnx](https://github.com/onnx/onnx/blob/master/docs/Operators.md) operators supported by each of the available backends. | |||
There was a problem hiding this comment.
There is a slight inconsistency in the URL mentioned here and that used to link to the specific operators below- 'master' branch vs 'rel1.2.3' (which should be OpSet v7). @fs-eire - which one should we keep ?
hariharans29
reviewed
Dec 7, 2018
README.md
Outdated
| | Android | :heavy_check_mark: | :heavy_check_mark: | Coming soon | - | :heavy_check_mark: | | ||
|
|
||
| ### Operators | ||
| ONNX.js currently supports most operators in [ai.onnx](https://github.com/onnx/onnx/blob/master/docs/Operators.md) operator set v7 (opset v7). See [operators.md](./docs/operators.md) for a complete, detailed list of which ONNX operators are supported by the 3 available builtin backends (cpu, wasm, and webgl). |
There was a problem hiding this comment.
same as the comment in ./docs/operators.md - 'master' vs 'rel-1.2.3' in the URL...
hariharans29
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.