Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the Graph header files and cleanup some issues. #42

Merged
merged 8 commits into from Nov 28, 2018
Merged

Document the Graph header files and cleanup some issues. #42

merged 8 commits into from Nov 28, 2018

Conversation

skottmckay
Copy link
Contributor

NOTE: The changes to .cc file and files outside of the Graph project are trivial adjustments to some methods using a reference instead of a pointer. As we're about to release now is the time to fix these things.

  • Document the header files for the Graph project
  • Fix some consistency issues to conform to the general approach of using a reference if something is never null to clearly advertise that to calling code.
    • Use reference for return value from ConstNodeIterator::operator* and Graph::AddNode, and in a few other minor places.
  • Fix some naming convention violations
  • Remove unnecessary "::onnxruntime::..." namespace qualifier usage
  • Remove some unused things
  • Fix some Code Analysis warnings
  • Few very minor tweaks

@skottmckay
Checkpoint.
ea82e24
@skottmckay
Add doco to graph.h and graph_base.h.
7668b09 
Change NodeConstIterator to return a reference to clearly advertise no nullptr's are going to be returned as it's only iterating valid Nodes.
Fix some code analysis warnings.
@skottmckay
Make a couple of APIs return a reference instead of a pointer as they…
98a23f1 
… never return nullptr.
@skottmckay
More doco and some minor naming cleanups.
fc66e10
@skottmckay
Merge
00e759b
@skottmckay
Cleanups
a2e6e57 
Couple more consistency changes.
pranavsharma
pranavsharma previously approved these changes Nov 28, 2018
View reviewed changes
@skottmckay skottmckay requested a review from a team as a code owner November 28, 2018 11:02
@pranavsharma pranavsharma merged commit bd50598 into master Nov 28, 2018
@skottmckay skottmckay deleted the scmckay/AddDocoToGraphAPI branch November 28, 2018 20:56
tmccrmck pushed a commit to tmccrmck/onnxruntime that referenced this pull request Aug 28, 2019
@NonStatic2014
Merge pull request microsoft#42 from NonStatic2014/bohu/empty_output_…
0c67e6d 
…filters

Handle empty output_filter field
natke referenced this pull request in natke/onnxruntime Feb 15, 2022
@chilo-ms
Refine BERT data reader to avoid OOM when doing dataset pre-processing (
fd38cd6 
#42)

* Handle OOM when using Percentile calibrator

* minor modification

* Modified code to reflect quantization tool

Co-authored-by: Chi Lo <Chi.Lo@gmail.com>
@lanyuer lanyuer mentioned this pull request May 16, 2022
Closed
@horror-proton horror-proton mentioned this pull request Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavsharma pranavsharma pranavsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skottmckay @pranavsharma