Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch mstest projects to use xunit #216

Merged
merged 2 commits into from
May 17, 2017
Merged

switch mstest projects to use xunit #216

merged 2 commits into from
May 17, 2017

Conversation

kayle
Copy link

@kayle kayle commented May 17, 2017

Fixes #207

@msftclas
Copy link

@kayle,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@kayle, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will definitely make #209 easier. It also moves the test suite in a direction of consistency with other open source Microsoft projects. The change to ETW_GeneralParsing_Basic could be seen as a concern, but I do not view it as such since our AppVeyor matrix validates pull requests against both the Debug and Release configurations. If a user working with a Release build locally saw an error appear on GitHub, it would be clear from the build report that it only occurred in a Debug configuration and they could switch to it locally to reproduce it.

@sharwell
Copy link
Member

Tagging @vancem for final acceptance.

@vancem
Copy link
Contributor

vancem commented May 17, 2017

LGTM

@vancem vancem merged commit c93a1b1 into microsoft:master May 17, 2017
@kayle kayle deleted the xunit branch May 17, 2017 14:26
@sharwell sharwell modified the milestone: 1.9.55 May 31, 2017
vancem added a commit to vancem/perfview that referenced this pull request Dec 20, 2017
switch mstest projects to use xunit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants