ContinueOnError, minor fixes #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added a ContinOneError option when creating an ETLX file. Basically if there is an error reading the input it simply stops converting and makes an ETLX file out of what it has. This is useful when there corruption, but it is not at the start. This not the default. PerfView uses it when the /ContinueOnError option is given. 2. Fixed issue with msdia140 not working on .NET Core properly (we were using foreach which drags in conversion routines not supported on .NET Core. 3. Added an explict reference to nuget.org when looking up packages. We have had people trying to build PerfView in environments that don't have this reference (they have a clone). 4. Added a 'ThreadState' entry ot the 'Blocked CSwitch' stack in the 'AnyStacks view'. This is useful.
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 17.51% 17.52% +<.01%
==========================================
Files 216 216
Lines 125013 125051 +38
Branches 12071 12077 +6
==========================================
+ Hits 21898 21911 +13
- Misses 102252 102278 +26
+ Partials 863 862 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a ContinOneError option when creating an ETLX file. Basically if there is an error reading the input it simply stops converting and makes an ETLX file out of what it has. This is useful when there corruption, but it is not at the start. This not the default. PerfView uses it when the /ContinueOnError option is given.
Fixed issue with msdia140 not working on .NET Core properly (we were using foreach which drags in conversion routines not supported on .NET Core.
Added an explict reference to nuget.org when looking up packages. We have had people trying to build PerfView in environments that don't have this reference (they have a clone).
Added a 'ThreadState' entry ot the 'Blocked CSwitch' stack in the 'AnyStacks view'. This is useful.