Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(20509, 20596): expect.toPass is broken with these #22254

Merged
merged 1 commit into from
Apr 11, 2023
Merged

revert(20509, 20596): expect.toPass is broken with these #22254

merged 1 commit into from
Apr 11, 2023

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Apr 6, 2023 •
edited by yury-s

Reverts #20509 and #20596
Fixes #22215

@aslushnikov aslushnikov merged commit c5aeab4 into microsoft:main Apr 11, 2023
19 of 20 checks passed
aslushnikov pushed a commit that referenced this pull request Apr 11, 2023
@pavelfeldman @aslushnikov
cherry-pick(#22254): revert(20509, 20596): expect.toPass is broken wi…
710674a 
…th these

Reverts #20509 and
#20596
Fixes #22215
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Apr 19, 2023
@pavelfeldman @sand4rt
revert(20509, 20596): expect.toPass is broken with these (microsoft#2…
d9d4f7b 
…2254)

Reverts microsoft#20509 and
microsoft#20596
Fixes microsoft#22215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Tests failing in toPass often marked as passed
3 participants
@pavelfeldman @yury-s @aslushnikov