Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swallow expect.soft errors inside successful toPass matcher #20509

Conversation

aslushnikov
Copy link
Collaborator

Fixes #20437

tests/playwright-test/expect-to-pass.spec.ts Show resolved Hide resolved
packages/playwright-test/src/common/testInfo.ts Outdated Show resolved Hide resolved
packages/playwright-test/src/matchers/matchers.ts Outdated Show resolved Hide resolved
packages/playwright-test/src/matchers/matchers.ts Outdated Show resolved Hide resolved
packages/playwright-test/src/matchers/matchers.ts Outdated Show resolved Hide resolved
@aslushnikov aslushnikov merged commit 4f61105 into microsoft:main Feb 2, 2023
@aslushnikov aslushnikov deleted the special-treatment-for-soft-asserts-inside-topass branch February 2, 2023 18:47
aslushnikov pushed a commit that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Expect.toPass to work with soft asserts
2 participants