-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lodash as dependencies #13
Remove lodash as dependencies #13
Conversation
@MrMeison, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update documentation as well. You should remove everything that related to lodash dependency
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "powerbi-visuals-utils-dataviewutils", | |||
"version": "1.1.1", | |||
"version": "1.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increase MINOR version
package.json
Outdated
"tslint": "4.4.2", | ||
"tslint-microsoft-contrib": "^4.0.1", | ||
"tslint": "5.4.3", | ||
"tslint-microsoft-contrib": "^5.0.0", | ||
"typescript": "2.1.4" | ||
}, | ||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this section.
test/dataRoleHelperTest.ts
Outdated
|
||
let dataView: DataView = dataViewBuilder.build(); | ||
|
||
let grouped = dataView.categorical.values.grouped(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify a type
test/dataRoleHelperTest.ts
Outdated
|
||
let grouped = dataView.categorical.values.grouped(); | ||
|
||
let result = DataRoleHelper.getMeasureIndexOfRole(grouped, ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify a type
No description provided.