Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in generated ServiceManifest.xml from VS template #1080

Closed
WhitWaldo opened this issue Nov 19, 2020 · 1 comment
Closed

Fix typo in generated ServiceManifest.xml from VS template #1080

WhitWaldo opened this issue Nov 19, 2020 · 1 comment
Assignees
Labels
area-SDK Relates to Service Fabric SDK and corresponding tooling support (including VS) area-Tooling Relates to questions or issues related to experience enabled in VS to deploy or manage SF apps

Comments

@WhitWaldo
Copy link

Service Fabric Runtime Version: 7.1.458

Environment: Must be one of these values [Standalone OR Azure OR OneBox/Dev cluster]
One-box, one-machine cluster

Description:
The current VS Service Fabric templates all generate a ServiceManifest.xml on which line 22 contains a typo. It produces a typo which reads:

  <!-- Config package is the contents of the Config directoy under PackageRoot that contains an 

Note that "directoy" is missing an "r". This has been bugging me since I've started using Service Fabric, so it's only just now occurred to me that I could file a ticket about it.

It's low priority, but it's got to be a pretty easy fix.

Observed behavior:
There's a typo in the generated ServiceManifest.xml file, at or around line 22.

Expected Behavior:
"directoy" is spelled correctly as "directory" in the generated ServiceManifest.xml file, at or around line 22.

OS(Windows/Linux): Windows

If this is a regression, which version did it regress from?
This has been an issue as long as I can recall.


Assignees: /cc @microsoft/service-fabric-triage

@athinanthny athinanthny added area-Common Relates to common building blocks, usually under the Common subfolder. and removed area-Common Relates to common building blocks, usually under the Common subfolder. labels Nov 19, 2020
@athinanthny athinanthny added area-Tooling Relates to questions or issues related to experience enabled in VS to deploy or manage SF apps area-SDK Relates to Service Fabric SDK and corresponding tooling support (including VS) labels Nov 19, 2020
@BigMorty
Copy link
Member

BigMorty commented Dec 8, 2020

This typo has been fixed in the next release (16.9 Preview 3) of the VS Service Fabric tools, thanks for reporting it!

@BigMorty BigMorty closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-SDK Relates to Service Fabric SDK and corresponding tooling support (including VS) area-Tooling Relates to questions or issues related to experience enabled in VS to deploy or manage SF apps
Projects
None yet
Development

No branches or pull requests

3 participants