Fix all high contrast issues in sqlops #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburtram
approved these changes
Apr 11, 2018
| @@ -56,7 +56,7 @@ | |||
| "tab.activeBackground": "#212121", | |||
| "tab.activeForeground": "#ffffff", | |||
| "tab.inactiveBackground": "#444444", | |||
| "tab.inactiveForeground": "#888888", | |||
| "tab.inactiveForeground": "#b6b6b6", | |||
There was a problem hiding this comment.
where did the new colors come from?
There was a problem hiding this comment.
@kburtram I worked with Smitha yesterday
| @@ -150,7 +150,9 @@ export const descriptionForeground = registerColor('descriptionForeground', { li | |||
|
|
|||
| export const focusBorder = registerColor('focusBorder', { dark: Color.fromHex('#0E639C').transparent(0.6), light: Color.fromHex('#007ACC').transparent(0.4), hc: '#F38518' }, nls.localize('focusBorder', "Overall border color for focused elements. This color is only used if not overridden by a component.")); | |||
|
|
|||
| export const contrastBorder = registerColor('contrastBorder', { light: null, dark: null, hc: '#6FC3DF' }, nls.localize('contrastBorder', "An extra border around elements to separate them from others for greater contrast.")); | |||
| // {{SQL CARBON EDIT}} -- Update contrastBorder color for HC | |||
| export const contrastBorder = registerColor('contrastBorder', { light: null, dark: null, hc: '#2b56f2' }, nls.localize('contrastBorder', "An extra border around elements to separate them from others for greater contrast.")); | |||
There was a problem hiding this comment.
do we know this isn't a problem for vs code? in other words, should this be fixed upstream?
There was a problem hiding this comment.
@kburtram I worked with Smitha yesterday. We used the boarder color in HC as the widget header background. That's the only color available when it is in HC theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility bugs:
11475139 Defect A11Y_SQLOpsStudio_RestoreDatabaseGeneral_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the table headers contents in "High Contrast" theme.
11475167 Defect A11Y_SQLOpsStudio_ServerDashboard_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the Tasks,Server Dashboard and Backup Status pane in "High Contrast" theme.
11475169 Defect A11y_SQLOpsStudio_Task_ColorContrast : Color Contrast ratio is less than 4.5:1 for the content under "Task History" in "Light SQLOpsStudio (default light)" theme.
11475456 Defect A11Y_SQLOpsStudio_ServerDashboard_ColorContrast: Color Contrast Ratio is less than 4.5:1 for some of the contents in Server Dashboard screen when "Default Light" theme is applied.
11511837 Defect A11Y_SQLOpsStudio_AccessibilityOptions_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the 4 Links present on the screen
11688190 Defect A11Y_SQLOpsStudio_RestoreDatabaseFiles_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the table headers contents in "High Contrast" theme.
11688194 Defect A11Y_SQLOpsStudio_ShowDetails(Insights)_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the table headers contents in "High Contrast" theme.
11688199 Defect A11Y_SQLOpsStudio_NewQueryExplainTopOperations_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the table headers contents in "High Contrast" theme.
11688348 Defect A11Y_SQLOpsStudio_NewQueryExplainTopOperations_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the non-selected tab items in "Kimbie Dark" theme.
11688349 Defect A11Y_SQLOpsStudio_NewQueryExplainChartViewer_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the non-selected tab items in "Kimbie Dark" theme.
11688353 Defect A11Y_SQLOpsStudio_NewQueryExplainQueryPlan_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the non-selected tab items in "Kimbie Dark" theme.
11688354 Defect A11Y_SQLOpsStudio_NewQueryExplainResults_ColorContrast: Color Contrast Ratio is less than 4.5:1 for the non-selected tab items in "Kimbie Dark" theme.