Remove cancellable task which does not cancel anything #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udeeshagautam
requested review from
pensivebrian,
anthonydresser,
kisantia and
kburtram
kisantia
approved these changes
Jun 3, 2019
|
holding it off since we are working on cancel operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : microsoft/azuredatastudio#5804
DacFx Api's does not allow cancel on generate script and apply operation.
But the default task created is in Task view has a context menu for cancel which is clickable and changes the UX to cancelled. This might create lot of confusion.
Reason : TaskInfo IsCancellable is set to true as long as task is has a "taskToCancel" object. This object is automatatically created based on Operation in current Create Task Call.
Fix: Setting the Task to cancel object to null explicitly since so that Iscancellable is set to false.
This is a temporary fix till DacFx Api changes are not in place for real cancellation.