Added delete materialized run endpoints #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istent with the rest of the codebase
…fetch template, materialized notebook endpoints. This will make the Notebook Request and Notebook History responses lighter.
…into feat/notebookendpoints
any injection attacks
leading zeros
…into feat/notebookendpoints
and fixed other stuff mentioned in the PR.
requests from multiple clients with materializedID = 0 could have resulted in multiple rows getting created on notebooks.nb_materialized table.
|
Hey @kburtram can you please take a look at this PR? |
kburtram
approved these changes
Sep 4, 2019
kburtram
reviewed
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added delete materialized run API.
Also modified some logic for rename and pin to support notebook runs that don't have a materialized notebook metadata in the database.