Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there any way to change the adapter to make "datarow" level in parallel? #452

Closed
Tracked by #910
jialihan opened this issue Jun 16, 2018 · 7 comments
Closed
Tracked by #910
Labels
Help-Wanted The issue is up-for-grabs, and can be claimed by commenting Type: Docs

Comments

@jialihan
Copy link

jialihan commented Jun 16, 2018

Description

I am trying to change the strategy of the original MSTest_Adapter to realize the parallel executing
on "DataRow" level in one method. I am asking is there any previous experience or trials on this topic?

AB#1408172

@pvlakshm
Copy link
Contributor

I am happy to know you are interested in contributing.
Parallelizing the execution of data driven tests is an interesting challenge.
The data can be static or dynamic or even coming from external sources.
Also, there are the semantics of the setup and teardown methods to consider.
Let me know your thoughts. Accordingly we can publish an RFC and take it from there.

@jayaranigarg jayaranigarg added tracking Help-Wanted The issue is up-for-grabs, and can be claimed by commenting Type: Docs labels Jun 27, 2018
@smalpani-gh
Copy link

Do let us know if you need any brainstorming on this topic to help with this contribution. Thanks again for your interest.

@jchesshir
Copy link

Note, some of the semantic challenges @pvlakshm noted are described in #385 and #386.

@Haplois
Copy link
Contributor

Haplois commented Oct 21, 2021

This behavior is enabled by default on version 2.2.7+.

@N-Olbert
Copy link

N-Olbert commented May 10, 2022

This behavior is enabled by default on version 2.2.7+.

@Haplois @nohwnd: Well... it’s a good feature, but the change of the default behaviour seems to be mentioned absolutely nowhere (also not in #910).
Shouldn't this be at least be mentioned in the release notes? I can imagine that this causes issues with some tests (whose [DataRow]'s are not thread-safe) and this specific issue is not the first place where i would expect such a change to be mentioned.

Also: Is there a way to revert this change without annotating the method as [DoNotParallize]? There are cases where it is fine to parallize a method in general, just not its [DataRow]'s. Also having parallized [DataRow]'s is very annoying during the debugging of tests.

@Haplois
Copy link
Contributor

Haplois commented May 10, 2022

Yes, please refer to this comment.

@mrubinstein
Copy link

This behavior is enabled by default on version 2.2.7+.

We are not seeing parallel execution at the data row level, using version 2.2.10.
Given the importance of this feature, it would be extremely helpful to document it (with setup), perhaps in the blog article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted The issue is up-for-grabs, and can be claimed by commenting Type: Docs
Projects
None yet
Development

No branches or pull requests

9 participants