Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run performance test #33

Closed
buybackoff opened this issue Jan 4, 2019 · 6 comments
Closed

Cannot run performance test #33

buybackoff opened this issue Jan 4, 2019 · 6 comments

Comments

@buybackoff
Copy link

Cannot run perf test. The error is in a generated file so cannot set a breakpoint and debug it easily as well. The code in the PerformanceTesting project hasn't changed since the initial commit and there is TODO in the generated file, so the question is if the test is supposed to work at all at the moment?

image

image

@peterfreiling-zz
Copy link

PR #34

@buybackoff
Copy link
Author

I have outputCount=0 on this line and printed performance at 1.8 billion input rows per second, which is about 2 CPU cycles per row and faster than a method call and doesn't look realistic.

@peterfreiling-zz
Copy link

Thanks. This will be addressed by PR #35. I've verified that the output is produced and a realistic performance number is logged.

@buybackoff
Copy link
Author

Thanks @peterfreiling. Still only the first test run prints sensible numbers. As if running the test has some side effect on inputs such as System.IO.Stream.Position...

The first run is cold and the number is lower than it should be. E.g. increasing row count by 10x increases the perf to c.10 MOPS.

image

@peterfreiling-zz
Copy link

Thanks @buybackoff, looks like this test has many issues! See PR #39.

@peterfreiling-zz
Copy link

PR completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants