Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

TypeScript 3.1 breaks the build: no "setImmediate" in typings #502

Closed
JoshuaKGoldberg opened this issue Sep 28, 2018 · 0 comments
Closed

TypeScript 3.1 breaks the build: no "setImmediate" in typings #502

JoshuaKGoldberg opened this issue Sep 28, 2018 · 0 comments
Assignees
@JoshuaKGoldberg
Labels
Domain: Tooling Repository tasks around improving source tooling. Type: Bug
Milestone
None

Comments

@JoshuaKGoldberg
Copy link

Example build:

test-data/NoStringBasedSetImmediateTestInput.ts(10,1): error TS2304: Cannot find name 'setImmediate'.

https://developer.mozilla.org/en-US/docs/Web/API/Window/setImmediate

We'll need to modify those tests to manually include typings for setImmediate.
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 28, 2018
@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Domain: Tooling Repository tasks around improving source tooling. labels Sep 28, 2018
JoshuaKGoldberg pushed a commit that referenced this issue Sep 28, 2018
Fixed setImmediate typings and deleted unused test file for TypeScrip…
a9931bd 
…t 3.1

Fixes #502
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 28, 2018
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Sep 28, 2018
Fixed setImmediate typings and deleted unused test file for TypeScrip…
6f5e5bf 
…t 3.1 (#503)

* Fixed setImmediate typings and deleted unused test file for TypeScript 3.1

Fixes #502

* Fixed the rest of compiles for test data

* Adjusted test lines
@JoshuaKGoldberg JoshuaKGoldberg added this to the None milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
Domain: Tooling Repository tasks around improving source tooling. Type: Bug
Projects
None yet
Milestone
None
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg