Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Commit

Permalink
Fixed setImmediate typings and deleted unused test file for TypeScrip…
Browse files Browse the repository at this point in the history 
…t 3.1 (#503)

* Fixed setImmediate typings and deleted unused test file for TypeScript 3.1

Fixes #502

* Fixed the rest of compiles for test data

* Adjusted test lines
  • Loading branch information
Josh Goldberg committed Sep 28, 2018
1 parent 32242fa commit 6f5e5bf
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 34 deletions.
34 changes: 17 additions & 17 deletions src/tests/NoStringBasedSetImmediateTests.ts
View file
Expand Up @@ -15,103 +15,103 @@ describe('noStringBasedSetImmediateRule', () : void => {
"failure": "Forbidden setImmediate string parameter: \"var x = 'should fail'\"",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 37, "character": 1 }
"startPosition": { "line": 46, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: typedStringVariable",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 38, "character": 1 }
"startPosition": { "line": 47, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: anyVariable",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 39, "character": 1 }
"startPosition": { "line": 48, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: untypedCreateFunction()",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 40, "character": 1 }
"startPosition": { "line": 49, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: stringFunction()",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 41, "character": 1 }
"startPosition": { "line": 50, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: \"var x = 'should fail'\"",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 42, "character": 1 }
"startPosition": { "line": 51, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: typedStringVariable",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 43, "character": 1 }
"startPosition": { "line": 52, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: anyVariable",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 44, "character": 1 }
"startPosition": { "line": 53, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: untypedCreateFunction()",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 45, "character": 1 }
"startPosition": { "line": 54, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: stringFunction()",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 46, "character": 1 }
"startPosition": { "line": 55, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: \"var x = 'should fail'\"",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 47, "character": 1 }
"startPosition": { "line": 56, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: typedStringVariable",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 48, "character": 1 }
"startPosition": { "line": 57, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: anyVariable",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 49, "character": 1 }
"startPosition": { "line": 58, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: untypedCreateFunction()",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 50, "character": 1 }
"startPosition": { "line": 59, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: stringFunction()",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 51, "character": 1 }
"startPosition": { "line": 60, "character": 1 }
},
{
"failure": "Forbidden setImmediate string parameter: stringArg",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 53, "character": 5 }
"startPosition": { "line": 62, "character": 5 }
},
{
"failure": "Forbidden setImmediate string parameter: anyArg",
"name": inputFile,
"ruleName": "no-string-based-set-immediate",
"startPosition": { "line": 56, "character": 5 }
"startPosition": { "line": 65, "character": 5 }
}
],
true);
Expand Down
2 changes: 1 addition & 1 deletion src/tests/NoStringBasedSetTimeoutTests.ts
View file
Expand Up @@ -105,7 +105,7 @@ describe('noStringBasedSetTimeoutRule', () : void => {
"failure": "Forbidden setTimeout string parameter: this.onAnimationEnd()",
"name": "test-data/NoStringBasedSetTimeout/NoStringBasedSetTimeoutTestInput-error4.ts",
"ruleName": "no-string-based-set-timeout",
"startPosition": { "line": 11, "character": 13 }
"startPosition": { "line": 12, "character": 13 }
}
]);
});
Expand Down
9 changes: 9 additions & 0 deletions test-data/NoStringBasedSetImmediateTestInput.ts
View file
@@ -1,3 +1,12 @@
// tslint:disable

declare const setImmediate: (...args: any[]) => number;

interface Window {
setImmediate: (...args: any[]) => number;
}

// tslint:enable

var typedStringVariable = 'string variable';
var functionVariable = () => {};
Expand Down
15 changes: 0 additions & 15 deletions test-data/NoStringBasedSetTimeout/NoStringBasedSetTimeoutFailingTestInput-walker-error.ts
View file

This file was deleted.

3 changes: 2 additions & 1 deletion test-data/NoStringBasedSetTimeout/NoStringBasedSetTimeoutTestInput-error4.ts
View file
Expand Up @@ -4,7 +4,8 @@ module SetTimeoutSample {

class MyClass {

private onAnimationEnd(): void {
private onAnimationEnd(): Function {
return () => {};
}

private method(): void {
Expand Down

0 comments on commit 6f5e5bf

Please sign in to comment.