[Qt5|qmake] pass toolchain setup #26354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for qt5-base have changed but the version was not updated
version: 5.15.5#2
old SHA: d827eb6115776d5cb8ec0d40205f93398ef669b3
new SHA: 50cd570c43131aa27d07211d7fb9a5e84a0772a9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Cheney-W
added
category:vcpkg-bug
JavierMatosD
added
requires:vcpkg-team-review
JavierMatosD
previously requested changes
Sep 1, 2022
JavierMatosD
added
requires:author-response
and removed
requires:vcpkg-team-review
Co-authored-by: Javier Matos Denizac <javier.matosd@gmail.com>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for qt5-base have changed but the version was not updated
version: 5.15.5#2
old SHA: 50cd570c43131aa27d07211d7fb9a5e84a0772a9
new SHA: c3d14cc7c6b29923bfcdbab8a96b7db2394f7684
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
@JavierMatosD Please review again, thank you! |
…olchain_setup # Conflicts: # ports/qt5-base/vcpkg.json # versions/baseline.json # versions/q-/qt5-base.json
daschuer
added a commit
to daschuer/vcpkg
that referenced
this pull request
Jan 19, 2023
The CMake flags have been already collected during configuring Qt5 base and are stored in qmodule.pri (<installed>\tools\qt5\mkspecs). The additional flag retrieving is disabled in qt_build_submodule.cmake This fixes a regression since microsoft#26354
daschuer
added a commit
to daschuer/vcpkg
that referenced
this pull request
May 2, 2023
The CMake flags have been already collected during configuring Qt5 base and are stored in qmodule.pri (<installed>\tools\qt5\mkspecs). The additional flag retrieving is disabled in qt_build_submodule.cmake This fixes a regression since microsoft#26354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one todo in #9881