[gdcm2] fix improper cmake file setup #4880
Conversation
ports/gdcm2/portfile.cmake
Outdated
| @@ -22,7 +21,7 @@ vcpkg_configure_cmake( | |||
| -DGDCM_INSTALL_INCLUDE_DIR=include | |||
| -DGDCM_USE_SYSTEM_EXPAT=ON | |||
| -DGDCM_USE_SYSTEM_ZLIB=ON | |||
| ${ADDITIONAL_OPTIONS} | |||
| -DGDCM_USE_SYSTEM_OPENJPEG=OFF | |||
There was a problem hiding this comment.
I think that this option is wrong, unless really necessary we should use system jpeg (and adding it to the "build-depends" field in the control file)
There was a problem hiding this comment.
I left this explicit OFF by intention. It still is a workaround for system open-jpeg cannot be found properly from gdcm2. Since gdcm2 provide its own bundle, I think it is still considered a "working" port, unless the bundled open-jpeg is not working as I assumed.
There was a problem hiding this comment.
what is the problem in finding the system jpeg? Something similar happens in other ports, usually it is just their "FindJPEG" that has to be patched (or fully removed so that the system one is used, which is supposed to work). Providing twice the same library (in case the user already has an OpenJPEG implementation installed) can bring in many problem for downstream projects
…g in Build-Depends list
|
Ok @cenit , check out the new commit to see if this patch work. I tested that on |
|
Thanks for the PR! (and @cenit for the review 👍 ) While merging, I replaced the cmake-file patching with |
move cmake files to proper location, and modify path in contents accordingly