Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% CPU load #2602

Closed
vasily-kirichenko opened this issue Mar 13, 2017 · 7 comments
Closed

100% CPU load #2602

vasily-kirichenko opened this issue Mar 13, 2017 · 7 comments
Labels
Area-LangService-API Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Milestone

Comments

@vasily-kirichenko
Copy link
Contributor

image

image

image

image

@vasily-kirichenko
Copy link
Contributor Author

@dsyme it's my, relatively new (post RTW) code:

 member x.IsDisposableType =
        if isUnresolved() then false else
        let ty = generalizedTyconRef entity
        Infos.ExistsHeadTypeInEntireHierarchy cenv.g cenv.amap range0 ty cenv.g.tcref_System_IDisposable

Please, help.

@cartermp cartermp added Area-LangService-API Tenet-Performance Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Mar 13, 2017
@cartermp cartermp added this to the VS 2017 Updates milestone Mar 13, 2017
@cartermp
Copy link
Contributor

@vasily-kirichenko Which PR was that?

@vasily-kirichenko
Copy link
Contributor Author

@cartermp #2488

@cartermp
Copy link
Contributor

Thanks! Is this on VisualFSharp.sln? If so, which file?

Interesting that this is happening. For some reason the loop within a loop is just slamming the dictionary in CanImportILType. Maybe there's a way to filter down what to look for prior to that?

@vasily-kirichenko
Copy link
Contributor Author

@cartermp many files were opened at that time :( One thing I can think about is trying to call IsDisposableType for IDisposable itself.

@dsyme
Copy link
Contributor

dsyme commented Mar 14, 2017

Either a quadratic (or worse) algorithm or a concurrency problem accessing that dictionary?

@vasily-kirichenko
Copy link
Contributor Author

I don't see this bug anymore.

@cartermp cartermp modified the milestones: VS 2017 Updates, 15.2 Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-API Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Projects
None yet
Development

No branches or pull requests

3 participants