Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the nightly auto publisher dead? #2664

Closed
vasily-kirichenko opened this issue Mar 20, 2017 · 9 comments
Closed

Is the nightly auto publisher dead? #2664

vasily-kirichenko opened this issue Mar 20, 2017 · 9 comments

Comments

@vasily-kirichenko
Copy link
Contributor

image

image

@majocha
Copy link
Contributor

majocha commented Mar 20, 2017

Switched off for the weekend? When Redmond wakes up someone will flip the switch back :)

@vasily-kirichenko
Copy link
Contributor Author

It works again...

@cartermp
Copy link
Contributor

@brettfo Would know more, but this could be due to one of two reasons:

  1. Coincidentally, no microbuild was kicked off
  2. No automated microbuild gets kicked off over the weekend

If it's the latter, maybe we can do something. Closing for now though, since the process isn't dead

@brettfo
Copy link
Member

brettfo commented Mar 20, 2017

In short, the package should get updated every morning, Monday through Friday.

Long answer:

  • A new package is published every time our internal microbuild branch builds successfully.
  • That branch is set to build on every push.
  • We have a scheduled task that merges master every weekday morning at 2am (Redmond time).
  • If there were no changes then there is no build.

We chose to not build on the weekends because there won't be anybody in the office to look at the build failures.

@forki
Copy link
Contributor

forki commented Mar 20, 2017 via email

@brettfo
Copy link
Member

brettfo commented Mar 20, 2017

If there is a build failure then no vsix will be produced

That's correct.

No need to disable

Nothing gets disabled on a build failure (or re-enabled on a build success.) The package upload is simply the last step of the build script so any failure before then will short-circuit the package publish step.

@forki
Copy link
Contributor

forki commented Mar 20, 2017 via email

@brettfo
Copy link
Member

brettfo commented Mar 20, 2017

Ahh, I understand the question now.

Ultimately it comes back to the part about nobody being in on the weekends to look at build failures. We try to keep our build queues green and if a build break gets merged on Friday afternoon, we'd have 3 red builds come Monday morning to triage; Saturday, Sunday, and Monday. Even though all three build failures would (likely) be the same issue, we've been asked to try to avoid build noise and our attempt at doing this is to simply not do a build when there'd be nobody to look at it.

This is also the same approach other VS teams use, including Roslyn, of not building on the weekend.

If we regularly start getting lots of code coming in on the weekends, we can revisit the option of running merges/builds every day.

@forki
Copy link
Contributor

forki commented Mar 20, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants