-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is the nightly auto publisher dead? #2664
Comments
Switched off for the weekend? When Redmond wakes up someone will flip the switch back :) |
It works again... |
@brettfo Would know more, but this could be due to one of two reasons:
If it's the latter, maybe we can do something. Closing for now though, since the process isn't dead |
In short, the package should get updated every morning, Monday through Friday. Long answer:
We chose to not build on the weekends because there won't be anybody in the office to look at the build failures. |
If there is a build failure then no vsix will be produced and we will wait
until Monday. No need to disable, right?
Am 20.03.2017 17:56 schrieb "Brett V. Forsgren" <notifications@github.com>:
… In short, the package should get updated every morning, Monday through
Friday.
Long answer:
- A new package is published every time our internal microbuild branch
builds successfully.
- That branch is set to build on every push.
- We have a scheduled task that merges master every weekday morning at
2am (Redmond time).
- If there were no changes then there is no build.
We chose to not build on the weekends because there won't be anybody in
the office to look at the build failures.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2664 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNCoHzWFVDN_UT1ImDMl29yHoJd1iks5rnr3LgaJpZM4MiRPO>
.
|
That's correct.
Nothing gets disabled on a build failure (or re-enabled on a build success.) The package upload is simply the last step of the build script so any failure before then will short-circuit the package publish step. |
No I meant no need to disable the build on weekends.
Am 20.03.2017 18:03 schrieb "Brett V. Forsgren" <notifications@github.com>:
… If there is a build failure then no vsix will be produced
That's correct.
No need to disable
Nothing gets disabled on a build failure (or re-enabled on a build
success.) The package upload is simply the last step of the build script so
any failure before then will short-circuit the package publish step.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2664 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNLE_f8WnLkh6xK2PUEl9oyeyyxJoks5rnr9qgaJpZM4MiRPO>
.
|
Ahh, I understand the question now. Ultimately it comes back to the part about nobody being in on the weekends to look at build failures. We try to keep our build queues green and if a build break gets merged on Friday afternoon, we'd have 3 red builds come Monday morning to triage; Saturday, Sunday, and Monday. Even though all three build failures would (likely) be the same issue, we've been asked to try to avoid build noise and our attempt at doing this is to simply not do a build when there'd be nobody to look at it. This is also the same approach other VS teams use, including Roslyn, of not building on the weekend. If we regularly start getting lots of code coming in on the weekends, we can revisit the option of running merges/builds every day. |
I think most of the code comes on weekends. But tbf if Kevin is not in the
office it usually would not land in master. So that's OK. I also now think
more important that build failure is a a big bug in the vsix itself. So if
a new vsix is released and nobody is there to roll it back then this can
indeed be bad. So I think I now agree. Keep it as is and don't release in
weekends.
Am 20.03.2017 18:16 schrieb "Brett V. Forsgren" <notifications@github.com>:
… Ahh, I understand the question now.
Ultimately it comes back to the part about nobody being in on the weekends
to look at build failures. We try to keep our build queues green and if a
build break gets merged on Friday afternoon, we'd have 3 red builds come
Monday morning to triage; Saturday, Sunday, and Monday. Even though all
three build failures would (likely) be the same issue, we've been asked to
try to avoid build noise and our attempt at doing this is to simply not do
a build when there'd be nobody to look at it.
This is also the same approach other VS teams use, including Roslyn, of
not building on the weekend.
If we regularly start getting lots of code coming in on the weekends, we
can revisit the option of running merges/builds every day.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2664 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNDNxnkQ7bjipwgcv9bNKNgxj7nAeks5rnsKTgaJpZM4MiRPO>
.
|
The text was updated successfully, but these errors were encountered: