-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail after FSharp.Core update to 4.5.2 #5814
Comments
Does the following signature info (delay-signed or test-signed) look as expected?
|
A workaround is to delete the file from the output directory by adding the following to tests projects:
|
cc @brettfo |
@auduchinok Does this still repro with FSharp.Core 4.5.4? |
@cartermp No, with FSharp.Core 4.5.4 it seems to work fine on the build server without the workaround above. However, looking at the package, there's a directory |
Not sure, but I know that those are a part of the TP smoke tests we do in CI ... no idea why anything from there would end up in the package. @KevinRansom since you added these tests, any ideas? |
No it shouldn't be there. |
4.6.0 still contains these files. |
@KevinRansom was this taken care of? |
Hmm … yes … I wonder if there was a merge issue. |
Except, I can't see a commit that would actually fix it. |
Okay, I propped the version of FSharp.Core that matches the FSharp shipped in Preview 2 of VS. That version didn't have the change that stops us adding UnitTests to the nuget package, because it is from early in December. We are preparing an insertion for Preview 3. As soon as that is confirmed I will prop the corresponding FSharp.Core 4.6.1 to nuget. It should happen by the end of next week. Kevin |
I can confirm FSharp.Core 4.6.1 doesn't have these files bundled. Thank you @KevinRansom. |
I've upgraded FSharp.Core package from
4.3.4
to4.5.2
in our solution and changed binding redirects accordingly:When I try to run tests on the build server, they fail due to strong name validation problems:
It seems to be related to #5224 (duplicates?) but the fix commit was merged before the 4.5.2 package release. I cannot reproduce it locally.
The text was updated successfully, but these errors were encountered: