Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Build visualfsharp with dotnet cli #958

Closed
5 of 12 tasks
enricosada opened this issue Feb 11, 2016 · 1 comment
Closed
5 of 12 tasks

[META] Build visualfsharp with dotnet cli #958

enricosada opened this issue Feb 11, 2016 · 1 comment

Comments

@enricosada
Copy link
Contributor

build visualfsharp (fsharp.core, fsc, fsi) with dotnet cli and project.json.

The dotnet cli build doesnt replace fsproj atm, it's used only to compile netcore version of FSharp.Core/fsc package and dogfood F# dotnet cli support (dotnet-compile-fsc)

Answered questions

How to declare defines per target profile

use compilationOptions under framework (ref compilationoptions docs.
That's needed to replace conditional defines in msbuild like

    <DefineConstants Condition="'$(TargetFramework)'=='coreclr'">$(DefineConstants);PREFERRED_UI_LANG</DefineConstants>

Open questions

How to generate and build fs source files

Some .fs source files need to be generated with FsSrGen and FsLexYacc.

It's possible to use the precompile script to run a tool (dotnet-fssrgen for example).
But dotnet build check if a source file (declared in the compileFiles) exists before of running precompile script, so stop build before generate the files.

Workaround: create an empty .fs file placeholder.
Long term: dotnet/cli#1475

@enricosada enricosada changed the title Build visualfsharp with dotnet cli [META] Build visualfsharp with dotnet cli Feb 25, 2016
@dsyme
Copy link
Contributor

dsyme commented Nov 8, 2016

I'm closing this as it is quite old and the various chances to the .NET CLI mean that the issue description would need to be rewritten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants