-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gcAllowVeryLargeObjects on FsiAnyCpu #2135
Enable gcAllowVeryLargeObjects on FsiAnyCpu #2135
Conversation
Hi @saul, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
I believe the warning applies also to libraries that are referenced using #r. I wonder whether this should be the only choice for 64 bit FSI or should it be an IDE option? |
Kevin if that's the case, then can't the user remove that line from the app config in the same way users currently add it? I can't imagine libraries that are assuming the maximum sizes of arrays are plentiful, especially so ones that are used often. Even if it were the case, it sounds like a bug with the library as opposed to FSI. |
@saul Without a decent explanation I don't know that I feel comfortable changing the default for FSI. Now I would be fine if there was an option in the VS tools to easily switch it. As for whether it's a bug or not in the library, it could be. However, it's a bug that an app developer would have to go out of his way to provoke, and so it may just be a thing. I would also guess that as well as switching the flag an ngen would be required for anything that is ngened. Anyway, let me have a root around and see if I can find ut why the default is the way it is. Kevin |
Hey Jan do you have any idea why the default for the 64 bit managed process gc has allow very large object false? Are there performance or compatability penalties associated with this option? Thanks Kevin |
I chatted with Vance. We can't think of any real issue with enabling this always in 64 bit FSI. |
Thank you for pushing on this. Kevin |
Fixes #100.
The documentation for this feature states:
I had a scan through the FSI code and took a look through the rest of the solution but found nothing of the sort.